ale64bit
  • Joined on 2023-03-06
ale64bit commented on pull request TrueCloudLab/frostfs-node#405 2023-05-29 12:47:47 +00:00
[#374] Add inner-ring event metrics

well, because my intention was to measure the actual event processor duration, excluding whatever wait time it spends on the pool. The pool wait time is statistically unrelated to the event…

ale64bit created pull request TrueCloudLab/frostfs-node#405 2023-05-29 09:05:38 +00:00
[#374] Add inner-ring event metrics
ale64bit pushed to feature/374-inner-ring-metrics at ale64bit/frostfs-node 2023-05-29 09:03:58 +00:00
0f7d3219b8 [#374] Add inner-ring event metrics
802168c0c6 [#364] node: Stop flushing big object when termination signal received
9c54a24101 [#364] Fix trailing whitespace
271a56c2ab [#395] metrics: Drop redundant metrics
bc34fee6a7 [#370] Add tree service metrics
Compare 9 commits »
ale64bit created branch feature/374-inner-ring-metrics in ale64bit/frostfs-node 2023-05-29 09:02:54 +00:00
ale64bit pushed to feature/374-inner-ring-metrics at ale64bit/frostfs-node 2023-05-29 09:02:54 +00:00
b6f3c8f3b4 [#374] Add inner-ring event metrics
2613351008 [#387] gc: Cancel GC is change mode requested
Compare 2 commits »
ale64bit commented on pull request TrueCloudLab/frostfs-sdk-go#78 2023-05-29 07:19:05 +00:00
[#76] netmap: Add new keyword NOT

not sure why not to just inline this expression, if it has only one production.

ale64bit commented on pull request TrueCloudLab/frostfs-node#388 2023-05-26 10:35:42 +00:00
[#370] Add tree service metrics

If by "ahh" you mean "I don't like this empty line", I removed it. I wish gofmt would eventually have a say on empty lines, to avoid wasting time discussing them.

ale64bit commented on pull request TrueCloudLab/frostfs-node#388 2023-05-26 10:34:55 +00:00
[#370] Add tree service metrics

the empty line seemed superfluous to me.

ale64bit commented on pull request TrueCloudLab/frostfs-node#388 2023-05-26 10:34:35 +00:00
[#370] Add tree service metrics

done

ale64bit commented on pull request TrueCloudLab/frostfs-node#388 2023-05-26 10:34:23 +00:00
[#370] Add tree service metrics

I moved it to clearly split the embedded fields from the others, including this one.

ale64bit pushed to feature/370-metrics-tree-service at ale64bit/frostfs-node 2023-05-26 10:34:15 +00:00
bfded3a547 [#370] Add tree service metrics
ale64bit commented on pull request TrueCloudLab/frostfs-node#388 2023-05-25 14:04:40 +00:00
[#370] Add tree service metrics

fixed

ale64bit commented on pull request TrueCloudLab/frostfs-node#388 2023-05-25 14:04:35 +00:00
[#370] Add tree service metrics

I agree it's better. Done.

ale64bit pushed to feature/370-metrics-tree-service at ale64bit/frostfs-node 2023-05-25 14:03:45 +00:00
87cc5877ef [#370] Add tree service metrics
ale64bit commented on pull request TrueCloudLab/frostfs-node#388 2023-05-25 13:52:27 +00:00
[#370] Add tree service metrics

You mean that should we just use a single HistogramVec for operations in general? (with a success label). Since it includes a count of the observations as well.

ale64bit commented on pull request TrueCloudLab/frostfs-node#388 2023-05-25 13:30:10 +00:00
[#370] Add tree service metrics

I didn't fully understand what you meant by "In fact, there is an operation that ended with an error or without an error."?

ale64bit commented on pull request TrueCloudLab/frostfs-node#388 2023-05-25 07:16:34 +00:00
[#370] Add tree service metrics

done. Thanks for the suggestion.

ale64bit pushed to feature/370-metrics-tree-service at ale64bit/frostfs-node 2023-05-25 07:16:07 +00:00
92f89d33b6 [#370] Add tree service metrics
ale64bit commented on pull request TrueCloudLab/frostfs-node#388 2023-05-24 11:56:52 +00:00
[#370] Add tree service metrics

done