ale64bit
0 followers · 0 following
  • Joined on 2023-03-06
Repositories
7
 Projects Packages Code Public activity Starred repositories
ale64bit commented on pull request TrueCloudLab/frostfs-node#388 2023-05-24 11:56:46 +00:00
[#370] Add tree service metrics

done

ale64bit commented on pull request TrueCloudLab/frostfs-node#388 2023-05-24 11:56:32 +00:00
[#370] Add tree service metrics

done

ale64bit commented on pull request TrueCloudLab/frostfs-node#388 2023-05-24 11:56:20 +00:00
[#370] Add tree service metrics

done

ale64bit commented on pull request TrueCloudLab/frostfs-node#388 2023-05-24 11:56:15 +00:00
[#370] Add tree service metrics

done

ale64bit pushed to feature/370-metrics-tree-service at ale64bit/frostfs-node 2023-05-24 11:55:58 +00:00
6d4047d00d [#370] Add tree service metrics
a1823423cf [#312] node: Add WC metrics info to CHANGELOG
2ce43935f9 [#312] metrics: Add writecache metrcis
d212d908b5 [#312] wc: Add metrics
4503a61997 [#312] wc: Delete unused Iterate method
Compare 17 commits »
ale64bit commented on pull request TrueCloudLab/frostfs-node#388 2023-05-24 08:58:56 +00:00
[#370] Add tree service metrics

I was concerned that if some of them failed too quick, they would skew the distribution of those that succeeded.

ale64bit created pull request TrueCloudLab/frostfs-node#388 2023-05-24 07:06:29 +00:00
[#370] Add tree service metrics
ale64bit pushed to feature/370-metrics-tree-service at ale64bit/frostfs-node 2023-05-24 07:05:45 +00:00
ee1aced7bd [#370] Add tree service metrics
ale64bit created branch feature/370-metrics-tree-service in ale64bit/frostfs-node 2023-05-24 07:02:46 +00:00
ale64bit pushed to feature/370-metrics-tree-service at ale64bit/frostfs-node 2023-05-24 07:02:46 +00:00
838b0d2102 [#370] Add tree service metrics
35c9b6b26d [#314] writecache: remove objects right after they are flushed
bf79d06f03 [#314] writecache: Do not lose small objects on disk errors
9e56592be3 [#314] writecache: Simplify background workers naming
483fac03d6 [#329] docs: Add shard evacuation description
Compare 10 commits »
ale64bit commented on pull request TrueCloudLab/frostfs-node#378 2023-05-23 10:23:21 +00:00
Write cache metrcis

if @dstepanov-yadro doesn't mind, that would be ideal.

ale64bit commented on pull request TrueCloudLab/frostfs-node#378 2023-05-23 10:09:33 +00:00
Write cache metrcis

eventually we will probably want to think about better structuring this (not specific to this PR). I suspect namespacing the metrics with prefixes in method names won't scale :))

ale64bit commented on pull request TrueCloudLab/frostfs-node#378 2023-05-23 10:07:00 +00:00
Write cache metrcis

I would personally avoid this sort of abbreviation in type names.

ale64bit approved TrueCloudLab/frostfs-node#378 2023-05-23 10:01:31 +00:00
Write cache metrcis
ale64bit commented on pull request TrueCloudLab/frostfs-node#378 2023-05-23 08:27:02 +00:00
Write cache metrcis

this interface should be exported if it's used as part of the public API of this package?

ale64bit commented on pull request TrueCloudLab/frostfs-node#378 2023-05-23 08:27:02 +00:00
Write cache metrcis

hmm, is it really better having these two vars assigned than just calling the c.metrics.Put where they are assigned? Following the flow seems a bit messier this way, IMHO.

ale64bit commented on pull request TrueCloudLab/frostfs-node#378 2023-05-23 08:27:02 +00:00
Write cache metrcis

s/wcMetrcis/wcMetrics

ale64bit commented on pull request TrueCloudLab/frostfs-node#378 2023-05-23 08:27:02 +00:00
Write cache metrcis

no need for pointer

ale64bit commented on pull request TrueCloudLab/frostfs-node#378 2023-05-23 08:27:02 +00:00
Write cache metrcis

I'm not sure, but do we actually need to pass these (i.e. m) using pointers?

ale64bit commented on pull request TrueCloudLab/frostfs-node#378 2023-05-23 08:27:02 +00:00
Write cache metrcis

you can just delete all placeholders, since none is used, e.g.