ale64bit
  • Joined on 2023-03-06
ale64bit commented on issue TrueCloudLab/frostfs-node#355 2023-05-17 08:15:39 +00:00
Errors 'too many open files' while load is running

Looks like the majority of them are network connections, so something is leaking those. I'm looking into it.

ale64bit commented on issue TrueCloudLab/frostfs-node#355 2023-05-17 07:50:59 +00:00
Errors 'too many open files' while load is running

@anikeev-yadro can you share the exact k6 command you used?

ale64bit commented on pull request TrueCloudLab/frostfs-node#354 2023-05-17 07:35:56 +00:00
[#352] Add explicit max number of alphabet nodes

done

ale64bit commented on pull request TrueCloudLab/frostfs-node#354 2023-05-17 07:35:41 +00:00
[#352] Add explicit max number of alphabet nodes

done

ale64bit pushed to fix/352-clarify-too-many-alpha-nodes at ale64bit/frostfs-node 2023-05-17 07:35:38 +00:00
99b4464674 [#352] Add explicit max number of alphabet nodes
ale64bit commented on pull request TrueCloudLab/frostfs-node#354 2023-05-16 13:22:37 +00:00
[#352] Add explicit max number of alphabet nodes

Actually, I apologize. I had this call in an earlier version but in current form ofc it's not necessary. I removed it.

ale64bit pushed to fix/352-clarify-too-many-alpha-nodes at ale64bit/frostfs-node 2023-05-16 13:22:09 +00:00
52fd548060 [#352] Add explicit max number of alphabet nodes
ale64bit commented on pull request TrueCloudLab/frostfs-node#354 2023-05-16 13:03:15 +00:00
[#352] Add explicit max number of alphabet nodes

Since this file is initialize_test.go and it tests initialization, I don't think this function should be calling test assertions since it's just a helper. This function marks it as such, so that…

ale64bit commented on pull request TrueCloudLab/frostfs-node#354 2023-05-16 13:01:13 +00:00
[#352] Add explicit max number of alphabet nodes

we can. But what's the benefit?

ale64bit commented on pull request TrueCloudLab/frostfs-node#354 2023-05-16 13:00:48 +00:00
[#352] Add explicit max number of alphabet nodes

it's not unrelated. A new constant was added and this one was moved into a const block, so the comment needs to be nested as well since it refers to the specific constant and not to the whole block.

ale64bit commented on pull request TrueCloudLab/frostfs-node#354 2023-05-16 13:00:00 +00:00
[#352] Add explicit max number of alphabet nodes

done

ale64bit commented on pull request TrueCloudLab/frostfs-node#354 2023-05-16 12:59:53 +00:00
[#352] Add explicit max number of alphabet nodes

done

ale64bit pushed to fix/352-clarify-too-many-alpha-nodes at ale64bit/frostfs-node 2023-05-16 12:59:49 +00:00
20661a0bc7 [#352] Add explicit max number of alphabet nodes
ale64bit commented on pull request TrueCloudLab/frostfs-node#353 2023-05-16 09:19:54 +00:00
Simplify write-cache (SUPPORT)

Disregarding the usage of TryLock which is usually a smell, I find the code really difficult to read and reason about. For example, I would be afraid of changing anything :) I'm not sure if some…

ale64bit created pull request TrueCloudLab/frostfs-dev-env#30 2023-05-16 08:58:51 +00:00
[#29] Remove prepare.ir make target
ale64bit created branch fix/29-remove-prepare-ir in ale64bit/frostfs-dev-env 2023-05-16 08:58:33 +00:00
ale64bit pushed to fix/29-remove-prepare-ir at ale64bit/frostfs-dev-env 2023-05-16 08:58:33 +00:00
2452e4469b [#29] Remove prepare.ir make target
ale64bit created repository ale64bit/frostfs-dev-env 2023-05-16 08:26:37 +00:00
ale64bit created pull request TrueCloudLab/frostfs-node#354 2023-05-16 08:24:07 +00:00
[#352] Add explicit max number of alphabet nodes
ale64bit created branch fix/352-clarify-too-many-alpha-nodes in ale64bit/frostfs-node 2023-05-16 08:22:43 +00:00