alexvanin/certificates
1
0
Fork 0
forked from TrueCloudLab/certificates
Code Pull requests Activity

acme/challenge: Fix error return type on KeyAuthorization

Browse source 
In golang, one should always return error types rather than interfaces
that conform to an error protocol. Why? Because of this:

    https://play.golang.org/p/MVa5vowuNRo

Feels ~~like JavaScript~~ bad, man.
This commit is contained in:
David Cowden 2020-05-11 21:26:21 -07:00
parent 9f18882973
commit 089e3aea4f
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
acme/challenge.go
View file

@ -621,7 +621,7 @@ func (dc *dns01Challenge) validate(jwk *jose.JSONWebKey, vo validateOptions) (ch
// KeyAuthorization creates the ACME key authorization value from a token // KeyAuthorization creates the ACME key authorization value from a token
// and a jwk. // and a jwk.
func KeyAuthorization(token string, jwk *jose.JSONWebKey) (string, *Error) { func KeyAuthorization(token string, jwk *jose.JSONWebKey) (string, error) {
thumbprint, err := jwk.Thumbprint(crypto.SHA256) thumbprint, err := jwk.Thumbprint(crypto.SHA256)
if err != nil { if err != nil {
return "", ServerInternalErr(errors.Wrap(err, "error generating JWK thumbprint")) return "", ServerInternalErr(errors.Wrap(err, "error generating JWK thumbprint"))