From 317efa456860d8265fa3730c513343db768249a0 Mon Sep 17 00:00:00 2001
From: Herman Slatman <hermanslatman@hotmail.com>
Date: Tue, 11 Oct 2022 17:39:35 +0200
Subject: [PATCH] Add some TODOs for improvingin PKI initialization
 maintainability

---
 pki/helm_test.go | 6 ++++++
 pki/pki.go       | 3 +++
 2 files changed, 9 insertions(+)

diff --git a/pki/helm_test.go b/pki/helm_test.go
index 703e6cb8..f83a8370 100644
--- a/pki/helm_test.go
+++ b/pki/helm_test.go
@@ -86,6 +86,12 @@ func TestPKI_WriteHelmTemplate(t *testing.T) {
 		t.Run(tt.name, func(t *testing.T) {
 			o := tt.fields.casOptions
 			opts := tt.fields.pkiOptions
+			// TODO(hs): invoking `New` doesn't perform all operations that are executed
+			// when `ca init --helm` is executed. The list of provisioners on the authority
+			// is not populated, for example, resulting in this test not being entirely
+			// realistic. Ideally this logic should be handled in one place and probably
+			// inside of the PKI initialization, but if that becomes messy, some more
+			// logic needs to be performed here to get the PKI instance in good shape.
 			p, err := New(o, opts...)
 			assert.NoError(t, err)
 			w := &bytes.Buffer{}
diff --git a/pki/pki.go b/pki/pki.go
index c05eadbd..5bbd42a1 100644
--- a/pki/pki.go
+++ b/pki/pki.go
@@ -307,6 +307,9 @@ type PKI struct {
 
 // New creates a new PKI configuration.
 func New(o apiv1.Options, opts ...Option) (*PKI, error) {
+	// TODO(hs): invoking `New` with a context active will use values from
+	// that CA context while generating the context. Thay may or may not
+	// be fully expected and/or what we want. Check that.
 	currentCtx := step.Contexts().GetCurrent()
 	caService, err := cas.New(context.Background(), o)
 	if err != nil {