alexvanin/certificates
1
0
Fork 0
forked from TrueCloudLab/certificates
Code Pull requests Activity

Merge pull request #1089 from smallstep/attestation-error

Browse source 
Revert ValidatedAt
This commit is contained in:
Mariano Cano 2022-10-03 13:15:42 -07:00 committed by GitHub
commit 818dffe6fe
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
acme/challenge.go
View file

@ -729,7 +729,6 @@ func storeError(ctx context.Context, db DB, ch *Challenge, markInvalid bool, err
ch.Error = err ch.Error = err
if markInvalid { if markInvalid {
ch.Status = StatusInvalid ch.Status = StatusInvalid
ch.ValidatedAt = clock.Now().Format(time.RFC3339)
} }
if err := db.UpdateChallenge(ctx, ch); err != nil { if err := db.UpdateChallenge(ctx, ch); err != nil {
return WrapErrorISE(err, "failure saving error to acme challenge") return WrapErrorISE(err, "failure saving error to acme challenge")

1
acme/challenge_test.go
View file

@ -170,7 +170,6 @@ func Test_storeError(t *testing.T) {
assert.Equals(t, updch.Token, ch.Token) assert.Equals(t, updch.Token, ch.Token)
assert.Equals(t, updch.Value, ch.Value) assert.Equals(t, updch.Value, ch.Value)
assert.Equals(t, updch.Status, StatusInvalid) assert.Equals(t, updch.Status, StatusInvalid)
assert.True(t, updch.ValidatedAt != "")
assert.HasPrefix(t, updch.Error.Err.Error(), err.Err.Error()) assert.HasPrefix(t, updch.Error.Err.Error(), err.Err.Error())
assert.Equals(t, updch.Error.Type, err.Type) assert.Equals(t, updch.Error.Type, err.Type)

2
acme/errors.go
View file

@ -75,6 +75,8 @@ func (ap ProblemType) String() string {
return "accountDoesNotExist" return "accountDoesNotExist"
case ErrorAlreadyRevokedType: case ErrorAlreadyRevokedType:
return "alreadyRevoked" return "alreadyRevoked"
case ErrorBadAttestationStatementType:
return "badAttestationStatement"
case ErrorBadCSRType: case ErrorBadCSRType:
return "badCSR" return "badCSR"
case ErrorBadNonceType: case ErrorBadNonceType: