alexvanin/certificates
1
0
Fork 0
forked from TrueCloudLab/certificates
Code Pull requests Activity

Merge pull request #1079 from smallstep/areed/fix-webhook-type

Browse source 
Fix webhook controller ignoring cert type
This commit is contained in:
Andrew Reed 2022-10-03 08:24:20 -05:00 committed by GitHub
commit 9b02b03293
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 18 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
authority/provisioner/controller.go
View file

@ -86,6 +86,7 @@ func (c *Controller) newWebhookController(templateData WebhookSetter, certType l
TemplateData: templateData,
client: client,
webhooks: c.webhooks,
certType: certType,
}
}

17
authority/provisioner/controller_test.go
View file

@ -8,6 +8,8 @@ import (
"testing"
"time"
"go.step.sm/crypto/x509util"
"go.step.sm/linkedca"
"golang.org/x/crypto/ssh"
"github.com/smallstep/certificates/authority/policy"
@ -445,3 +447,18 @@ func TestDefaultAuthorizeSSHRenew(t *testing.T) {
})
}
}
func Test_newWebhookController(t *testing.T) {
c := &Controller{}
data := x509util.TemplateData{"foo": "bar"}
ctl := c.newWebhookController(data, linkedca.Webhook_X509)
if !reflect.DeepEqual(ctl.TemplateData, data) {
t.Error("Failed to set templateData")
}
if ctl.certType != linkedca.Webhook_X509 {
t.Error("Failed to set certType")
}
if ctl.client == nil {
t.Error("Failed to set client")
}
}