Verify IP identifier contains valid IP

This commit is contained in:
Herman Slatman 2021-06-03 22:02:13 +02:00
parent 6486e6016b
commit a0e92f8e99
No known key found for this signature in database
GPG key ID: F4D8A44EA0A75A4F

View file

@ -5,6 +5,7 @@ import (
"crypto/x509"
"encoding/base64"
"encoding/json"
"net"
"net/http"
"strings"
"time"
@ -31,6 +32,9 @@ func (n *NewOrderRequest) Validate() error {
if !(id.Type == "dns" || id.Type == "ip") {
return acme.NewError(acme.ErrorMalformedType, "identifier type unsupported: %s", id.Type)
}
if id.Type == "ip" && net.ParseIP(id.Value) == nil {
return acme.NewError(acme.ErrorMalformedType, "%s is not a valid IP address", id.Value)
}
}
return nil
}
@ -85,6 +89,7 @@ func (h *Handler) NewOrder(w http.ResponseWriter, r *http.Request) {
"failed to unmarshal new-order request payload"))
return
}
if err := nor.Validate(); err != nil {
api.WriteError(w, err)
return