alexvanin/certificates
1
0
Fork 0
forked from TrueCloudLab/certificates
Code Pull requests Activity

Fix linter errors

Browse source
This commit is contained in:
Mariano Cano 2022-09-21 14:56:15 -07:00
parent 325d8bca4f
commit a6e85cbbf6
1 changed files with 14 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
authority/internal/constraints/verify.go
View file

@ -37,7 +37,7 @@ import (
"strings" "strings"
) )
func checkNameConstraints(nameType string, name string, parsedName any, permitted, excluded any, match func(name, constraint any) (bool, error)) error { func checkNameConstraints(nameType, name string, parsedName, permitted, excluded any, match func(name, constraint any) (bool, error)) error {
excludedValue := reflect.ValueOf(excluded) excludedValue := reflect.ValueOf(excluded)
for i := 0; i < excludedValue.Len(); i++ { for i := 0; i < excludedValue.Len(); i++ {
constraint := excludedValue.Index(i).Interface() constraint := excludedValue.Index(i).Interface()
@ -92,7 +92,7 @@ func checkNameConstraints(nameType string, name string, parsedName any, permitte
func matchDomainConstraint(domain, constraint string) (bool, error) { func matchDomainConstraint(domain, constraint string) (bool, error) {
// The meaning of zero length constraints is not specified, but this // The meaning of zero length constraints is not specified, but this
// code follows NSS and accepts them as matching everything. // code follows NSS and accepts them as matching everything.
if len(constraint) == 0 { if constraint == "" {
return true, nil return true, nil
} }
@ -101,10 +101,10 @@ func matchDomainConstraint(domain, constraint string) (bool, error) {
return false, fmt.Errorf("internal error: cannot parse domain %q", domain) return false, fmt.Errorf("internal error: cannot parse domain %q", domain)
} }
// RFC 5280 says that a leading period in a domain name means that at // RFC 5280 says that a leading period in a domain name means that at least
// least one label must be prepended, but only for URI and email // one label must be prepended, but only for URI and email constraints, not
// constraints, not DNS constraints. The code also supports that // DNS constraints. The code also supports that behavior for DNS
// behaviour for DNS constraints. // constraints.
mustHaveSubdomains := false mustHaveSubdomains := false
if constraint[0] == '.' { if constraint[0] == '.' {
@ -180,7 +180,7 @@ func matchURIConstraint(uri *url.URL, constraint string) (bool, error) {
// certificate.” // certificate.”
host := uri.Host host := uri.Host
if len(host) == 0 { if host == "" {
return false, fmt.Errorf("URI with empty host (%q) cannot be matched against constraints", uri.String()) return false, fmt.Errorf("URI with empty host (%q) cannot be matched against constraints", uri.String())
} }
@ -213,13 +213,13 @@ func domainToReverseLabels(domain string) (reverseLabels []string, ok bool) {
} }
} }
if len(reverseLabels) > 0 && len(reverseLabels[0]) == 0 { if len(reverseLabels) > 0 && reverseLabels[0] == "" {
// An empty label at the end indicates an absolute value. // An empty label at the end indicates an absolute value.
return nil, false return nil, false
} }
for _, label := range reverseLabels { for _, label := range reverseLabels {
if len(label) == 0 { if label == "" {
// Empty labels are otherwise invalid. // Empty labels are otherwise invalid.
return nil, false return nil, false
} }
@ -247,7 +247,7 @@ type rfc2821Mailbox struct {
// Section 4.2.1.6 that's correct for an rfc822Name from a certificate: “The // Section 4.2.1.6 that's correct for an rfc822Name from a certificate: “The
// format of an rfc822Name is a "Mailbox" as defined in RFC 2821, Section 4.1.2”. // format of an rfc822Name is a "Mailbox" as defined in RFC 2821, Section 4.1.2”.
func parseRFC2821Mailbox(in string) (mailbox rfc2821Mailbox, ok bool) { func parseRFC2821Mailbox(in string) (mailbox rfc2821Mailbox, ok bool) {
if len(in) == 0 { if in == "" {
return mailbox, false return mailbox, false
} }
@ -267,7 +267,7 @@ func parseRFC2821Mailbox(in string) (mailbox rfc2821Mailbox, ok bool) {
in = in[1:] in = in[1:]
QuotedString: QuotedString:
for { for {
if len(in) == 0 { if in == "" {
return mailbox, false return mailbox, false
} }
c := in[0] c := in[0]
@ -279,7 +279,7 @@ func parseRFC2821Mailbox(in string) (mailbox rfc2821Mailbox, ok bool) {
case c == '\\': case c == '\\':
// quoted-pair // quoted-pair
if len(in) == 0 { if in == "" {
return mailbox, false return mailbox, false
} }
if in[0] == 11 || if in[0] == 11 ||
@ -328,7 +328,7 @@ func parseRFC2821Mailbox(in string) (mailbox rfc2821Mailbox, ok bool) {
// continue to argue the point. We choose to // continue to argue the point. We choose to
// accept it. // accept it.
in = in[1:] in = in[1:]
if len(in) == 0 { if in == "" {
return mailbox, false return mailbox, false
} }
fallthrough fallthrough
@ -365,7 +365,7 @@ func parseRFC2821Mailbox(in string) (mailbox rfc2821Mailbox, ok bool) {
} }
} }
if len(in) == 0 || in[0] != '@' { if in == "" || in[0] != '@' {
return mailbox, false return mailbox, false
} }
in = in[1:] in = in[1:]