alexvanin/certificates
1
0
Fork 0
forked from TrueCloudLab/certificates
Code Pull requests Activity

Log certificate's serial number as stringified decimal number

Browse source 
Using a JSON string fixes a common issue with JSON parsers that
deserialize all numbers to a 64-bit IEEE-754 floats. (Certificate
serial numbers are usually 128 bit values.)

This change is consistent with existing log entries for revocation
requests.

See also: #630, #631
This commit is contained in:
Hilko Bengen 2021-07-14 11:25:56 +02:00
parent b9743b36e1
commit edb01bc9f2
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
api/api.go
View file

@ -400,7 +400,7 @@ func logOtt(w http.ResponseWriter, token string) {
func LogCertificate(w http.ResponseWriter, cert *x509.Certificate) { func LogCertificate(w http.ResponseWriter, cert *x509.Certificate) {
if rl, ok := w.(logging.ResponseLogger); ok { if rl, ok := w.(logging.ResponseLogger); ok {
m := map[string]interface{}{ m := map[string]interface{}{
"serial": cert.SerialNumber, "serial": cert.SerialNumber.String(),
"subject": cert.Subject.CommonName, "subject": cert.Subject.CommonName,
"issuer": cert.Issuer.CommonName, "issuer": cert.Issuer.CommonName,
"valid-from": cert.NotBefore.Format(time.RFC3339), "valid-from": cert.NotBefore.Format(time.RFC3339),