alexvanin/certificates
1
0
Fork 0
forked from TrueCloudLab/certificates
Code Pull requests Activity

cas/cloudcas: update test on createPublicKey for the next Go release

Browse source 
The next Go release call panic on elliptic.Marshal [1][2], which
affect the test case fail_ec_marshal on createPublicKey.

This changes fix this by initializing the P and B in test case
PublicKey CurveParams to prevent panic.

[1] https://github.com/golang/go/issues/50975
[2] a218b3520a
This commit is contained in:
Shulhan 2022-06-16 02:34:20 +07:00
parent 304cc5a70f
commit ee53530d1f
No known key found for this signature in database
GPG key ID: F8507EE9148A4CE3
1 changed files with 9 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
cas/cloudcas/certificate_test.go
View file

@ -112,6 +112,7 @@ func Test_createPublicKey(t *testing.T) {
t.Fatal(err)
}
ecCert := mustParseCertificate(t, testLeafCertificate)
ecCertPublicKey := ecCert.PublicKey.(*ecdsa.PublicKey)
rsaCert := mustParseCertificate(t, testRSACertificate)
type args struct {
key crypto.PublicKey
@ -132,9 +133,14 @@ func Test_createPublicKey(t *testing.T) {
}, false},
{"fail ed25519", args{edpub}, nil, true},
{"fail ec marshal", args{&ecdsa.PublicKey{
Curve: &elliptic.CurveParams{Name: "FOO", BitSize: 256},
X: ecCert.PublicKey.(*ecdsa.PublicKey).X,
Y: ecCert.PublicKey.(*ecdsa.PublicKey).Y,
Curve: &elliptic.CurveParams{
Name: "FOO",
BitSize: 256,
P: ecCertPublicKey.Params().P,
B: ecCertPublicKey.Params().B,
},
X: ecCertPublicKey.X,
Y: ecCertPublicKey.Y,
}}, nil, true},
}
for _, tt := range tests {