alexvanin/certificates
1
0
Fork 0
forked from TrueCloudLab/certificates
Code Pull requests Activity

Merge pull request #1109 from smallstep/herman/remove-acme-revoke-authorization-todo

Browse source 
Remove TODO and clarify ACME revoke authorization method docs
This commit is contained in:
Herman Slatman 2022-10-17 19:14:18 +02:00 committed by GitHub
commit f7d153efa7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
authority/provisioner/acme.go
View file

@ -260,16 +260,15 @@ func (p *ACME) AuthorizeSign(ctx context.Context, token string) ([]SignOption, e
} }
// AuthorizeRevoke is called just before the certificate is to be revoked by // AuthorizeRevoke is called just before the certificate is to be revoked by
// the CA. It can be used to authorize revocation of a certificate. It // the CA. It can be used to authorize revocation of a certificate. With the
// currently is a no-op. // ACME protocol, revocation authorization is specified and performed as part
// TODO(hs): add configuration option that toggles revocation? Or change function signature to make it more useful? // of the client/server interaction, so this is a no-op.
// Or move certain logic out of the Revoke API to here? Would likely involve some more stuff in the ctx.
func (p *ACME) AuthorizeRevoke(ctx context.Context, token string) error { func (p *ACME) AuthorizeRevoke(ctx context.Context, token string) error {
return nil return nil
} }
// AuthorizeRenew returns an error if the renewal is disabled. // AuthorizeRenew returns an error if the renewal is disabled.
// NOTE: This method does not actually validate the certificate or check it's // NOTE: This method does not actually validate the certificate or check its
// revocation status. Just confirms that the provisioner that created the // revocation status. Just confirms that the provisioner that created the
// certificate was configured to allow renewals. // certificate was configured to allow renewals.
func (p *ACME) AuthorizeRenew(ctx context.Context, cert *x509.Certificate) error { func (p *ACME) AuthorizeRenew(ctx context.Context, cert *x509.Certificate) error {