From 20525e390a3cc5aa627cf7ecbb6ae637001fedcf Mon Sep 17 00:00:00 2001 From: Aaron Lehmann Date: Thu, 31 Mar 2016 11:00:28 -0700 Subject: [PATCH] Makefile: don't look for golint and godep in specific places Using $GOPATH/bin/godep or $GOPATH/bin/golint is problematic because $GOPATH can contain multiple colon-separated paths. We should just run these like normal binaries. The user should make sure their $PATH contains $GOPATH/bin, if necessary. This is part of normal Go setup. Signed-off-by: Aaron Lehmann --- Makefile | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/Makefile b/Makefile index d27bcb27..a0602d0b 100644 --- a/Makefile +++ b/Makefile @@ -31,11 +31,8 @@ GO15VENDOREXPERIMENT := 1 PKGS := $(shell go list -tags "${DOCKER_BUILDTAGS}" ./... | grep -v ^github.com/docker/distribution/vendor/) # Resolving binary dependencies for specific targets -GOLINT_BIN := $(GOPATH)/bin/golint -GOLINT := $(shell [ -x $(GOLINT_BIN) ] && echo $(GOLINT_BIN) || echo '') - -GODEP_BIN := $(GOPATH)/bin/godep -GODEP := $(shell [ -x $(GODEP_BIN) ] && echo $(GODEP_BIN) || echo '') +GOLINT := $(shell which golint || echo '') +GODEP := $(shell which godep || echo '') ${PREFIX}/bin/registry: $(wildcard **/*.go) @echo "+ $@"