From f4d5210b25e934b2910676e0b340a2e11766819c Mon Sep 17 00:00:00 2001 From: Milos Gajdos Date: Fri, 22 Sep 2023 16:21:54 +0100 Subject: [PATCH] Do not close HTTP request body in HTTP handler Signed-off-by: Milos Gajdos --- registry/handlers/app.go | 2 -- registry/handlers/tags.go | 2 -- 2 files changed, 4 deletions(-) diff --git a/registry/handlers/app.go b/registry/handlers/app.go index 73680fd3..8efdaf85 100644 --- a/registry/handlers/app.go +++ b/registry/handlers/app.go @@ -584,8 +584,6 @@ func (app *App) configureSecret(configuration *configuration.Configuration) { } func (app *App) ServeHTTP(w http.ResponseWriter, r *http.Request) { - defer r.Body.Close() // ensure that request body is always closed. - // Prepare the context with our own little decorations. ctx := r.Context() ctx = dcontext.WithRequest(ctx, r) diff --git a/registry/handlers/tags.go b/registry/handlers/tags.go index ec0eb233..bfd56fc6 100644 --- a/registry/handlers/tags.go +++ b/registry/handlers/tags.go @@ -34,8 +34,6 @@ type tagsAPIResponse struct { // GetTags returns a json list of tags for a specific image name. func (th *tagsHandler) GetTags(w http.ResponseWriter, r *http.Request) { - defer r.Body.Close() - tagService := th.Repository.Tags(th) tags, err := tagService.All(th) if err != nil {