From f78d81e78a20fda60efb4a29848f77d99dd0513b Mon Sep 17 00:00:00 2001 From: James Hewitt Date: Fri, 12 Aug 2022 16:03:19 +0100 Subject: [PATCH] Remove test as S3 does not support empty directories Signed-off-by: James Hewitt --- registry/storage/driver/s3-aws/s3_test.go | 33 ----------------------- 1 file changed, 33 deletions(-) diff --git a/registry/storage/driver/s3-aws/s3_test.go b/registry/storage/driver/s3-aws/s3_test.go index 0c79a009..e4fe1793 100644 --- a/registry/storage/driver/s3-aws/s3_test.go +++ b/registry/storage/driver/s3-aws/s3_test.go @@ -205,39 +205,6 @@ func TestEmptyRootList(t *testing.T) { } } -// TestWalkEmptySubDirectory assures we list an empty sub directory only once when walking -// through its parent directory. -func TestWalkEmptySubDirectory(t *testing.T) { - if skipS3() != "" { - t.Skip(skipS3()) - } - - drv, err := s3DriverConstructor("", s3.StorageClassStandard) - if err != nil { - t.Fatalf("unexpected error creating rooted driver: %v", err) - } - - // create an empty sub directory. - s3driver := drv.StorageDriver.(*driver) - if _, err := s3driver.S3.PutObject(&s3.PutObjectInput{ - Bucket: aws.String(os.Getenv("S3_BUCKET")), - Key: aws.String("/testdir/emptydir/"), - }); err != nil { - t.Fatalf("error creating empty directory: %s", err) - } - - bucketFiles := []string{} - s3driver.Walk(context.Background(), "/testdir", func(fileInfo storagedriver.FileInfo) error { - bucketFiles = append(bucketFiles, fileInfo.Path()) - return nil - }) - - expected := []string{"/testdir/emptydir"} - if !reflect.DeepEqual(bucketFiles, expected) { - t.Errorf("expecting files %+v, found %+v instead", expected, bucketFiles) - } -} - func TestStorageClass(t *testing.T) { if skipS3() != "" { t.Skip(skipS3())