alexvanin/distribution
1
0
Fork 0
forked from TrueCloudLab/distribution
Code Pull requests Activity

registry/api/errorcode: TestErrorCodes: use sub-tests

Browse source 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This commit is contained in:
Sebastiaan van Stijn 2023-04-30 15:23:44 +02:00
parent 57f9f31af9
commit f884a079df
No known key found for this signature in database
GPG key ID: 76698F39D527CE8C
1 changed files with 41 additions and 37 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

78
registry/api/errcode/errors_test.go
View file

@ -34,57 +34,61 @@ var ErrorCodeTest3 = Register("test.errors", ErrorDescriptor{
// TestErrorCodes ensures that error code format, mappings and // TestErrorCodes ensures that error code format, mappings and
// marshaling/unmarshaling. round trips are stable. // marshaling/unmarshaling. round trips are stable.
func TestErrorCodes(t *testing.T) { func TestErrorCodes(t *testing.T) {
t.Parallel()
if len(errorCodeToDescriptors) == 0 { if len(errorCodeToDescriptors) == 0 {
t.Fatal("errors aren't loaded!") t.Fatal("errors aren't loaded!")
} }
for ec, desc := range errorCodeToDescriptors { for ec, desc := range errorCodeToDescriptors {
if ec != desc.Code { t.Run(ec.String(), func(t *testing.T) {
t.Fatalf("error code in descriptor isn't correct, %q != %q", ec, desc.Code) t.Parallel()
} if ec != desc.Code {
t.Fatalf("error code in descriptor isn't correct, %q != %q", ec, desc.Code)
}
if idToDescriptors[desc.Value].Code != ec { if idToDescriptors[desc.Value].Code != ec {
t.Fatalf("error code in idToDesc isn't correct, %q != %q", idToDescriptors[desc.Value].Code, ec) t.Fatalf("error code in idToDesc isn't correct, %q != %q", idToDescriptors[desc.Value].Code, ec)
} }
if ec.Message() != desc.Message { if ec.Message() != desc.Message {
t.Fatalf("ec.Message doesn't mtach desc.Message: %q != %q", ec.Message(), desc.Message) t.Fatalf("ec.Message doesn't match desc.Message: %q != %q", ec.Message(), desc.Message)
} }
// Test (de)serializing the ErrorCode // Test (de)serializing the ErrorCode
p, err := json.Marshal(ec) p, err := json.Marshal(ec)
if err != nil { if err != nil {
t.Fatalf("couldn't marshal ec %v: %v", ec, err) t.Fatalf("couldn't marshal ec %v: %v", ec, err)
} }
if len(p) <= 0 { if len(p) <= 0 {
t.Fatalf("expected content in marshaled before for error code %v", ec) t.Fatalf("expected content in marshaled before for error code %v", ec)
} }
// First, unmarshal to interface and ensure we have a string. // First, unmarshal to interface and ensure we have a string.
var ecUnspecified interface{} var ecUnspecified interface{}
if err := json.Unmarshal(p, &ecUnspecified); err != nil { if err := json.Unmarshal(p, &ecUnspecified); err != nil {
t.Fatalf("error unmarshaling error code %v: %v", ec, err) t.Fatalf("error unmarshaling error code %v: %v", ec, err)
} }
if _, ok := ecUnspecified.(string); !ok { if _, ok := ecUnspecified.(string); !ok {
t.Fatalf("expected a string for error code %v on unmarshal got a %T", ec, ecUnspecified) t.Fatalf("expected a string for error code %v on unmarshal got a %T", ec, ecUnspecified)
} }
// Now, unmarshal with the error code type and ensure they are equal // Now, unmarshal with the error code type and ensure they are equal
var ecUnmarshaled ErrorCode var ecUnmarshaled ErrorCode
if err := json.Unmarshal(p, &ecUnmarshaled); err != nil { if err := json.Unmarshal(p, &ecUnmarshaled); err != nil {
t.Fatalf("error unmarshaling error code %v: %v", ec, err) t.Fatalf("error unmarshaling error code %v: %v", ec, err)
} }
if ecUnmarshaled != ec { if ecUnmarshaled != ec {
t.Fatalf("unexpected error code during error code marshal/unmarshal: %v != %v", ecUnmarshaled, ec) t.Fatalf("unexpected error code during error code marshal/unmarshal: %v != %v", ecUnmarshaled, ec)
} }
expectedErrorString := strings.ToLower(strings.Replace(ec.Descriptor().Value, "_", " ", -1)) expectedErrorString := strings.ToLower(strings.Replace(ec.Descriptor().Value, "_", " ", -1))
if ec.Error() != expectedErrorString { if ec.Error() != expectedErrorString {
t.Fatalf("unexpected return from %v.Error(): %q != %q", ec, ec.Error(), expectedErrorString) t.Fatalf("unexpected return from %v.Error(): %q != %q", ec, ec.Error(), expectedErrorString)
} }
})
} }
} }