forked from TrueCloudLab/distribution
a18cc8a656
Stat always calls ListObjects when stat-ing S3 key. Unfortauntely ListObjects is not a free call - both in terms of egress and actual AWS costs (likely because of the egress). This changes the behaviour of Stat such that we always attempt the HeadObject call first and only ever fall through to ListObjects if the HeadObject returns an AWS API error. Note, that the official docs mention that the only error returned by HEAD is NoSuchKey; experiments show that this is demonstrably wrong and the AWS docs are simply outdated at the time of this commit. HeadObject actually returns the following errors: * NotFound: if the queried key does not exist * NotFound: if the queried key contains subkeys i.e. it's a prefix * BucketRegionError: if the bucket does not exist * Forbidden: if Head operation is not allows via IAM/ACLs Co-authored-by: Cory Snider <corhere@gmail.com> Co-authored-by: Sebastiaan van Stijn <github@gone.nl> Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Signed-off-by: Milos Gajdos <milosthegajdos@gmail.com> |
||
|---|---|---|
| .. | ||
| cache | ||
| driver | ||
| blob_test.go | ||
| blobserver.go | ||
| blobstore.go | ||
| blobwriter.go | ||
| blobwriter_nonresumable.go | ||
| blobwriter_resumable.go | ||
| catalog.go | ||
| catalog_test.go | ||
| doc.go | ||
| error.go | ||
| filereader.go | ||
| filereader_test.go | ||
| garbagecollect.go | ||
| garbagecollect_test.go | ||
| io.go | ||
| linkedblobstore.go | ||
| linkedblobstore_test.go | ||
| manifestlisthandler.go | ||
| manifeststore.go | ||
| manifeststore_test.go | ||
| ociindexhandler.go | ||
| ocimanifesthandler.go | ||
| ocimanifesthandler_test.go | ||
| paths.go | ||
| paths_test.go | ||
| purgeuploads.go | ||
| purgeuploads_test.go | ||
| registry.go | ||
| schema2manifesthandler.go | ||
| schema2manifesthandler_test.go | ||
| tagstore.go | ||
| tagstore_test.go | ||
| vacuum.go | ||