From e0ab9294103bab4a6cf96c5500a5430069d0fce7 Mon Sep 17 00:00:00 2001
From: Denis Kirillov <denis@nspcc.ru>
Date: Thu, 25 Aug 2022 09:36:38 +0300
Subject: [PATCH] [#194] Use gauge instead of counter for metrics

Signed-off-by: Denis Kirillov <denis@nspcc.ru>
---
 metrics/metrics.go | 26 ++++++++++++++------------
 1 file changed, 14 insertions(+), 12 deletions(-)

diff --git a/metrics/metrics.go b/metrics/metrics.go
index 9c79189..52b5e88 100644
--- a/metrics/metrics.go
+++ b/metrics/metrics.go
@@ -42,9 +42,9 @@ type stateMetrics struct {
 
 type poolMetricsCollector struct {
 	pool                *pool.Pool
-	overallErrors       prometheus.Counter
-	overallNodeErrors   *prometheus.CounterVec
-	overallNodeRequests *prometheus.CounterVec
+	overallErrors       prometheus.Gauge
+	overallNodeErrors   *prometheus.GaugeVec
+	overallNodeRequests *prometheus.GaugeVec
 	currentErrors       *prometheus.GaugeVec
 	requestDuration     *prometheus.GaugeVec
 }
@@ -83,8 +83,8 @@ func (m stateMetrics) SetHealth(s int32) {
 }
 
 func newPoolMetricsCollector(p *pool.Pool) *poolMetricsCollector {
-	overallErrors := prometheus.NewCounter(
-		prometheus.CounterOpts{
+	overallErrors := prometheus.NewGauge(
+		prometheus.GaugeOpts{
 			Namespace: namespace,
 			Subsystem: poolSubsystem,
 			Name:      "overall_errors",
@@ -92,8 +92,8 @@ func newPoolMetricsCollector(p *pool.Pool) *poolMetricsCollector {
 		},
 	)
 
-	overallNodeErrors := prometheus.NewCounterVec(
-		prometheus.CounterOpts{
+	overallNodeErrors := prometheus.NewGaugeVec(
+		prometheus.GaugeOpts{
 			Namespace: namespace,
 			Subsystem: poolSubsystem,
 			Name:      "overall_node_errors",
@@ -104,8 +104,8 @@ func newPoolMetricsCollector(p *pool.Pool) *poolMetricsCollector {
 		},
 	)
 
-	overallNodeRequests := prometheus.NewCounterVec(
-		prometheus.CounterOpts{
+	overallNodeRequests := prometheus.NewGaugeVec(
+		prometheus.GaugeOpts{
 			Namespace: namespace,
 			Subsystem: poolSubsystem,
 			Name:      "overall_node_requests",
@@ -175,18 +175,20 @@ func (m *poolMetricsCollector) register() {
 func (m *poolMetricsCollector) updateStatistic() {
 	stat := m.pool.Statistic()
 
+	m.overallNodeErrors.Reset()
+	m.overallNodeRequests.Reset()
 	m.currentErrors.Reset()
 	m.requestDuration.Reset()
 
 	for _, node := range stat.Nodes() {
-		m.overallNodeErrors.WithLabelValues(node.Address()).Add(float64(node.OverallErrors()))
-		m.overallNodeRequests.WithLabelValues(node.Address()).Add(float64(node.Requests()))
+		m.overallNodeErrors.WithLabelValues(node.Address()).Set(float64(node.OverallErrors()))
+		m.overallNodeRequests.WithLabelValues(node.Address()).Set(float64(node.Requests()))
 
 		m.currentErrors.WithLabelValues(node.Address()).Set(float64(node.CurrentErrors()))
 		m.updateRequestsDuration(node)
 	}
 
-	m.overallErrors.Add(float64(stat.OverallErrors()))
+	m.overallErrors.Set(float64(stat.OverallErrors()))
 }
 
 func (m *poolMetricsCollector) updateRequestsDuration(node pool.NodeStatistic) {