forked from TrueCloudLab/frostfs-node
[#959] writecache: Avoid manipulation with cache in DEGRADED
mode
Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
This commit is contained in:
parent
d433b49265
commit
3195142d67
6 changed files with 35 additions and 1 deletions
|
@ -19,6 +19,7 @@ import (
|
||||||
//
|
//
|
||||||
// Returns an error of type apistatus.ObjectNotFound if object is missing in write-cache.
|
// Returns an error of type apistatus.ObjectNotFound if object is missing in write-cache.
|
||||||
// Returns ErrNotInitialized if write-cache has not been initialized yet.
|
// Returns ErrNotInitialized if write-cache has not been initialized yet.
|
||||||
|
// Returns ErrDegraded if write-cache is in DEGRADED mode.
|
||||||
func (c *cache) Delete(ctx context.Context, addr oid.Address) error {
|
func (c *cache) Delete(ctx context.Context, addr oid.Address) error {
|
||||||
ctx, span := tracing.StartSpanFromContext(ctx, "writecache.Delete",
|
ctx, span := tracing.StartSpanFromContext(ctx, "writecache.Delete",
|
||||||
trace.WithAttributes(
|
trace.WithAttributes(
|
||||||
|
@ -40,6 +41,9 @@ func (c *cache) Delete(ctx context.Context, addr oid.Address) error {
|
||||||
if c.readOnly() {
|
if c.readOnly() {
|
||||||
return ErrReadOnly
|
return ErrReadOnly
|
||||||
}
|
}
|
||||||
|
if c.noMetabase() {
|
||||||
|
return ErrDegraded
|
||||||
|
}
|
||||||
|
|
||||||
saddr := addr.EncodeToString()
|
saddr := addr.EncodeToString()
|
||||||
|
|
||||||
|
|
|
@ -155,7 +155,7 @@ func (c *cache) workerFlushBig(ctx context.Context) {
|
||||||
select {
|
select {
|
||||||
case <-tick.C:
|
case <-tick.C:
|
||||||
c.modeMtx.RLock()
|
c.modeMtx.RLock()
|
||||||
if c.readOnly() {
|
if c.readOnly() || c.noMetabase() {
|
||||||
c.modeMtx.RUnlock()
|
c.modeMtx.RUnlock()
|
||||||
break
|
break
|
||||||
}
|
}
|
||||||
|
@ -281,6 +281,9 @@ func (c *cache) Flush(ctx context.Context, ignoreErrors, seal bool) error {
|
||||||
|
|
||||||
c.modeMtx.Lock() // exclusive lock to not to conflict with background flush
|
c.modeMtx.Lock() // exclusive lock to not to conflict with background flush
|
||||||
defer c.modeMtx.Unlock()
|
defer c.modeMtx.Unlock()
|
||||||
|
if c.noMetabase() {
|
||||||
|
return ErrDegraded
|
||||||
|
}
|
||||||
|
|
||||||
if err := c.flush(ctx, ignoreErrors); err != nil {
|
if err := c.flush(ctx, ignoreErrors); err != nil {
|
||||||
return err
|
return err
|
||||||
|
|
|
@ -29,6 +29,14 @@ func (c *cache) Get(ctx context.Context, addr oid.Address) (*objectSDK.Object, e
|
||||||
))
|
))
|
||||||
defer span.End()
|
defer span.End()
|
||||||
|
|
||||||
|
if !c.modeMtx.TryRLock() {
|
||||||
|
return nil, ErrNotInitialized
|
||||||
|
}
|
||||||
|
defer c.modeMtx.RUnlock()
|
||||||
|
if c.mode.NoMetabase() {
|
||||||
|
return nil, ErrDegraded
|
||||||
|
}
|
||||||
|
|
||||||
obj, err := c.getInternal(ctx, saddr, addr)
|
obj, err := c.getInternal(ctx, saddr, addr)
|
||||||
return obj, metaerr.Wrap(err)
|
return obj, metaerr.Wrap(err)
|
||||||
}
|
}
|
||||||
|
@ -71,6 +79,14 @@ func (c *cache) Head(ctx context.Context, addr oid.Address) (*objectSDK.Object,
|
||||||
))
|
))
|
||||||
defer span.End()
|
defer span.End()
|
||||||
|
|
||||||
|
if !c.modeMtx.TryRLock() {
|
||||||
|
return nil, ErrNotInitialized
|
||||||
|
}
|
||||||
|
defer c.modeMtx.RUnlock()
|
||||||
|
if c.mode.NoMetabase() {
|
||||||
|
return nil, ErrDegraded
|
||||||
|
}
|
||||||
|
|
||||||
obj, err := c.getInternal(ctx, saddr, addr)
|
obj, err := c.getInternal(ctx, saddr, addr)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return nil, metaerr.Wrap(err)
|
return nil, metaerr.Wrap(err)
|
||||||
|
|
|
@ -76,3 +76,9 @@ func (c *cache) setMode(ctx context.Context, m mode.Mode, ignoreErrors bool) err
|
||||||
func (c *cache) readOnly() bool {
|
func (c *cache) readOnly() bool {
|
||||||
return c.mode.ReadOnly()
|
return c.mode.ReadOnly()
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// noMetabase returns true if c is operating without the metabase.
|
||||||
|
// `c.modeMtx` must be taken.
|
||||||
|
func (c *cache) noMetabase() bool {
|
||||||
|
return c.mode.NoMetabase()
|
||||||
|
}
|
||||||
|
|
|
@ -41,6 +41,9 @@ func (c *cache) Put(ctx context.Context, prm common.PutPrm) (common.PutRes, erro
|
||||||
if c.readOnly() {
|
if c.readOnly() {
|
||||||
return common.PutRes{}, ErrReadOnly
|
return common.PutRes{}, ErrReadOnly
|
||||||
}
|
}
|
||||||
|
if c.noMetabase() {
|
||||||
|
return common.PutRes{}, ErrDegraded
|
||||||
|
}
|
||||||
|
|
||||||
sz := uint64(len(prm.RawData))
|
sz := uint64(len(prm.RawData))
|
||||||
if sz > c.maxObjectSize {
|
if sz > c.maxObjectSize {
|
||||||
|
|
|
@ -59,6 +59,8 @@ type Metabase interface {
|
||||||
var (
|
var (
|
||||||
// ErrReadOnly is returned when Put/Write is performed in a read-only mode.
|
// ErrReadOnly is returned when Put/Write is performed in a read-only mode.
|
||||||
ErrReadOnly = logicerr.New("write-cache is in read-only mode")
|
ErrReadOnly = logicerr.New("write-cache is in read-only mode")
|
||||||
|
// ErrDegraded is returned when writecache is in degraded mode.
|
||||||
|
ErrDegraded = logicerr.New("write-cache is in degraded mode")
|
||||||
// ErrNotInitialized is returned when write-cache is initializing.
|
// ErrNotInitialized is returned when write-cache is initializing.
|
||||||
ErrNotInitialized = logicerr.New("write-cache is not initialized yet")
|
ErrNotInitialized = logicerr.New("write-cache is not initialized yet")
|
||||||
// ErrBigObject is returned when object is too big to be placed in cache.
|
// ErrBigObject is returned when object is too big to be placed in cache.
|
||||||
|
|
Loading…
Reference in a new issue