alexvanin/rclone
1
0
Fork 0
forked from TrueCloudLab/rclone
Code Pull requests Activity

oauthutil: fix crash when webrowser requests /robots.txt - fixes #5836

Browse source 
Before this change the oauth webserver would crash if it received a
request to /robots.txt.

This patch makes it ignore (with 404 error) any paths it isn't
expecting.
This commit is contained in:
Nick Craig-Wood 2021-11-24 13:08:25 +00:00
parent 46175a22d8
commit 3425726c50
1 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
lib/oauthutil/oauthutil.go
View file

@ -691,6 +691,11 @@ func newAuthServer(opt *Options, bindAddress, state, authURL string) *authServer
// Receive the auth request // Receive the auth request
func (s *authServer) handleAuth(w http.ResponseWriter, req *http.Request) { func (s *authServer) handleAuth(w http.ResponseWriter, req *http.Request) {
if req.URL.Path != "/" {
fs.Debugf(nil, "Ignoring %s request on auth server to %q", req.Method, req.URL.Path)
http.NotFound(w, req)
return
}
fs.Debugf(nil, "Received %s request on auth server to %q", req.Method, req.URL.Path) fs.Debugf(nil, "Received %s request on auth server to %q", req.Method, req.URL.Path)
// Reply with the response to the user and to the channel // Reply with the response to the user and to the channel
@ -752,10 +757,6 @@ func (s *authServer) Init() error {
} }
s.server.SetKeepAlivesEnabled(false) s.server.SetKeepAlivesEnabled(false)
mux.HandleFunc("/favicon.ico", func(w http.ResponseWriter, req *http.Request) {
http.Error(w, "", http.StatusNotFound)
return
})
mux.HandleFunc("/auth", func(w http.ResponseWriter, req *http.Request) { mux.HandleFunc("/auth", func(w http.ResponseWriter, req *http.Request) {
state := req.FormValue("state") state := req.FormValue("state")
if state != s.state { if state != s.state {