alexvanin/rclone
1
0
Fork 0
forked from TrueCloudLab/rclone
Code Pull requests Activity

compress: fix crash if metadata upload failed - fixes #5994

Browse source 
Before this changed the backend attempted to delete a nil object if
the metadata upload failed.
This commit is contained in:
Nick Craig-Wood 2022-02-16 11:42:28 +00:00
parent 8ee0fe9863
commit 71a784cfa2
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
backend/compress/compress.go
View file

@ -626,9 +626,11 @@ func (f *Fs) putMetadata(ctx context.Context, meta *ObjectMetadata, src fs.Objec
// Put the data // Put the data
mo, err = put(ctx, metaReader, f.wrapInfo(src, makeMetadataName(src.Remote()), int64(len(data))), options...) mo, err = put(ctx, metaReader, f.wrapInfo(src, makeMetadataName(src.Remote()), int64(len(data))), options...)
if err != nil { if err != nil {
removeErr := mo.Remove(ctx) if mo != nil {
if removeErr != nil { removeErr := mo.Remove(ctx)
fs.Errorf(mo, "Failed to remove partially transferred object: %v", err) if removeErr != nil {
fs.Errorf(mo, "Failed to remove partially transferred object: %v", err)
}
} }
return nil, err return nil, err
} }