alexvanin/rclone
1
0
Fork 0
forked from TrueCloudLab/rclone
Code Pull requests Activity

vfs: [bugfix] Update dir modification time

Browse source 
A subtle bug where dir modification time is not updated when the dir already exists
in the cache. It is only noticeable when some clients use dir modification time to
invalidate cache.
This commit is contained in:
Saleh Dindar 2023-09-24 14:51:08 -07:00 committed by Nick Craig-Wood
parent 23f8dea182
commit 7801b160f2
1 changed files with 7 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
vfs/dir.go
View file

@ -694,9 +694,10 @@ func (d *Dir) _readDirFromEntries(entries fs.DirEntries, dirTree dirtree.DirTree
if node == nil || !node.IsDir() {
node = newDir(d.vfs, d.f, d, item)
}
if dirTree != nil {
dir := node.(*Dir)
dir.mu.Lock()
dir.modTime = item.ModTime(context.TODO())
if dirTree != nil {
err = dir._readDirFromDirTree(dirTree, when)
if err != nil {
dir.read = time.Time{}
@ -704,11 +705,11 @@ func (d *Dir) _readDirFromEntries(entries fs.DirEntries, dirTree dirtree.DirTree
dir.read = when
dir.cleanupTimer.Reset(d.vfs.Opt.DirCacheTime * 2)
}
}
dir.mu.Unlock()
if err != nil {
return err
}
}
default:
err = fmt.Errorf("unknown type %T", item)
fs.Errorf(d, "readDir error: %v", err)