alexvanin/restic
1
0
Fork 0
forked from TrueCloudLab/restic
Code Pull requests Activity
restic/changelog/unreleased/pull-4958

8 lines
285 B
Text
Raw Normal View History

restore: clean up error handling when restoring metadata - Fix a logic error that instead of reporting the *first* metadata-setting error that appears, we were instead reporting the *last* error (and only if the lchown call failed!). - Don't show any errors when setting metadata for files in non-root mode (things like timestamps, attributes). Previously, only lchown errors were skipped. But other kinds of attribute errors make sense to skip as well. The code path happened to work correctly before because of the above logic error. But once that was fixed, this change needed to happen too.
2024-07-27 22:55:00 +00:00
Bugfix: Don't ignore metadata-setting errors during restore
cleanup changelogs
2024-08-30 12:58:32 +00:00
Restic ignored errors when setting timestamps, attributes, or file modes during
a restore. It now reports those, except for permission errors when running
without root privileges.
restore: clean up error handling when restoring metadata - Fix a logic error that instead of reporting the *first* metadata-setting error that appears, we were instead reporting the *last* error (and only if the lchown call failed!). - Don't show any errors when setting metadata for files in non-root mode (things like timestamps, attributes). Previously, only lchown errors were skipped. But other kinds of attribute errors make sense to skip as well. The code path happened to work correctly before because of the above logic error. But once that was fixed, this change needed to happen too.
2024-07-27 22:55:00 +00:00
https://github.com/restic/restic/pull/4958
Copy permalink