From 16fd1c2352ed9326ed6eadfd61ae4e461e219371 Mon Sep 17 00:00:00 2001
From: Alexander Neumann <alexander@bumpern.de>
Date: Mon, 17 Apr 2017 20:06:06 +0200
Subject: [PATCH] s3: Correct layout handle url/path

---
 src/restic/backend/layout_s3.go   | 20 ++++++++++++++++++--
 src/restic/backend/layout_test.go | 18 ++++++++++++++++++
 2 files changed, 36 insertions(+), 2 deletions(-)

diff --git a/src/restic/backend/layout_s3.go b/src/restic/backend/layout_s3.go
index 9db8ae7f3..91273d63a 100644
--- a/src/restic/backend/layout_s3.go
+++ b/src/restic/backend/layout_s3.go
@@ -18,13 +18,29 @@ var s3LayoutPaths = map[restic.FileType]string{
 	restic.KeyFile:      "key",
 }
 
+// join calls Join with the first empty elements removed.
+func (l *S3Layout) join(url string, items ...string) string {
+	for len(items) > 0 && items[0] == "" {
+		items = items[1:]
+	}
+
+	path := l.Join(items...)
+	if path == "" || path[0] != '/' {
+		if url != "" && url[len(url)-1] != '/' {
+			url += "/"
+		}
+	}
+
+	return url + path
+}
+
 // Dirname returns the directory path for a given file type and name.
 func (l *S3Layout) Dirname(h restic.Handle) string {
 	if h.Type == restic.ConfigFile {
 		return l.URL + l.Join(l.Path, "/")
 	}
 
-	return l.URL + l.Join(l.Path, "/", s3LayoutPaths[h.Type]) + "/"
+	return l.join(l.URL, l.Path, s3LayoutPaths[h.Type]) + "/"
 }
 
 // Filename returns a path to a file, including its name.
@@ -35,7 +51,7 @@ func (l *S3Layout) Filename(h restic.Handle) string {
 		name = "config"
 	}
 
-	return l.URL + l.Join(l.Path, "/", s3LayoutPaths[h.Type], name)
+	return l.join(l.URL, l.Path, s3LayoutPaths[h.Type], name)
 }
 
 // Paths returns all directory names
diff --git a/src/restic/backend/layout_test.go b/src/restic/backend/layout_test.go
index 4fee713cb..606da3241 100644
--- a/src/restic/backend/layout_test.go
+++ b/src/restic/backend/layout_test.go
@@ -190,6 +190,24 @@ func TestCloudLayoutURLs(t *testing.T) {
 			"https://hostname.foo:1234/prefix/repo/config",
 			"https://hostname.foo:1234/prefix/repo/",
 		},
+		{
+			&S3Layout{URL: "", Path: "", Join: path.Join},
+			restic.Handle{Type: restic.DataFile, Name: "foobar"},
+			"data/foobar",
+			"data/",
+		},
+		{
+			&S3Layout{URL: "", Path: "", Join: path.Join},
+			restic.Handle{Type: restic.LockFile, Name: "foobar"},
+			"lock/foobar",
+			"lock/",
+		},
+		{
+			&S3Layout{URL: "", Path: "/", Join: path.Join},
+			restic.Handle{Type: restic.ConfigFile, Name: "foobar"},
+			"/config",
+			"/",
+		},
 	}
 
 	for _, test := range tests {