alexvanin/restic
1
0
Fork 0
forked from TrueCloudLab/restic
Code Pull requests Activity

fix: rclone receiving SIGINT prematurely on Windows causing restic hang forever

Browse source 
Co-authored-by: greatroar <61184462+greatroar@users.noreply.github.com>
This commit is contained in:
Charlie Jiang 2021-12-22 16:32:23 +08:00
parent 882d58abce
commit a5b0e0bef4
2 changed files with 15 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
changelog/unreleased/issue-3601 Normal file
View file

@ -0,0 +1,11 @@
Bugfix: Fix rclone backend prematurely exiting when receiving SIGINT on Windows
On Windows, Restic now start the rclone process detached from the
restic console (similar to starting processes on a new process
group on Linux). Therefore, when Ctrl+C is pressed on the console
where restic runs, restic could gracefully clean up using clone,
and rclone won't exit prematurely leading to restic hanging up with
"stdio pipes closed" errors.
https://github.com/restic/restic/issue/3601
https://github.com/restic/restic/pull/3602

4
internal/backend/foreground_windows.go
View file

@ -2,12 +2,16 @@ package backend
import ( import (
"os/exec" "os/exec"
"syscall"
"github.com/restic/restic/internal/errors" "github.com/restic/restic/internal/errors"
"golang.org/x/sys/windows"
) )
func startForeground(cmd *exec.Cmd) (bg func() error, err error) { func startForeground(cmd *exec.Cmd) (bg func() error, err error) {
// just start the process and hope for the best // just start the process and hope for the best
cmd.SysProcAttr = &syscall.SysProcAttr{}
cmd.SysProcAttr.CreationFlags = windows.DETACHED_PROCESS
err = cmd.Start() err = cmd.Start()
if err != nil { if err != nil {
return nil, errors.Wrap(err, "cmd.Start") return nil, errors.Wrap(err, "cmd.Start")