alexvanin/restic
1
0
Fork 0
forked from TrueCloudLab/restic
Code Pull requests Activity

fs: Use AT_FDCWD in Linux nodeRestoreSymlinkTimestamps

Browse source 
There's no need to open the containing directory. This is exactly what
syscall.UtimesNano does, except for the AT_SYMLINK_NOFOLLOW flag.
This commit is contained in:
greatroar 2024-10-04 11:06:26 +02:00
parent 7c02141548
commit f967a33ccc
1 changed files with 3 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
internal/fs/node_linux.go
View file

@ -1,33 +1,18 @@
package fs package fs
import ( import (
"os"
"path/filepath"
"syscall" "syscall"
"golang.org/x/sys/unix"
"github.com/restic/restic/internal/errors" "github.com/restic/restic/internal/errors"
"golang.org/x/sys/unix"
) )
func nodeRestoreSymlinkTimestamps(path string, utimes [2]syscall.Timespec) error { func nodeRestoreSymlinkTimestamps(path string, utimes [2]syscall.Timespec) error {
dir, err := os.Open(fixpath(filepath.Dir(path)))
if err != nil {
return errors.WithStack(err)
}
times := []unix.Timespec{ times := []unix.Timespec{
{Sec: utimes[0].Sec, Nsec: utimes[0].Nsec}, {Sec: utimes[0].Sec, Nsec: utimes[0].Nsec},
{Sec: utimes[1].Sec, Nsec: utimes[1].Nsec}, {Sec: utimes[1].Sec, Nsec: utimes[1].Nsec},
} }
err = unix.UtimesNanoAt(int(dir.Fd()), filepath.Base(path), times, unix.AT_SYMLINK_NOFOLLOW) err := unix.UtimesNanoAt(unix.AT_FDCWD, path, times, unix.AT_SYMLINK_NOFOLLOW)
if err != nil {
// ignore subsequent errors
_ = dir.Close()
return errors.Wrap(err, "UtimesNanoAt") return errors.Wrap(err, "UtimesNanoAt")
} }
return dir.Close()
}