From 23f571f76fc2c91a3311eb360470fc4d0875247c Mon Sep 17 00:00:00 2001 From: Leonard Lyubich Date: Thu, 6 Aug 2020 02:09:44 +0300 Subject: [PATCH] object: Remove response meta header This commit removes ResponseMetaHeader from the repository since it is not verifiable and its purpose is questionable. If needed, it can be added to queries without losing compatibility with the API version. Signed-off-by: Leonard Lyubich --- object/service.proto | 15 --------------- proto-docs/object.md | 10 ---------- proto-docs/service.md | 14 -------------- service/meta.proto | 10 ---------- 4 files changed, 49 deletions(-) diff --git a/object/service.proto b/object/service.proto index 573e068..bf369fa 100644 --- a/object/service.proto +++ b/object/service.proto @@ -71,9 +71,6 @@ message GetResponse { // Chunk of remaining payload bytes Chunk = 2; } - - // ResponseMetaHeader contains meta information based on request processing by server (should be embedded into message) - service.ResponseMetaHeader Meta = 99; } message PutRequest { @@ -100,8 +97,6 @@ message PutRequest { message PutResponse { // Address of object (container id + object id) refs.Address Address = 1; - // ResponseMetaHeader contains meta information based on request processing by server (should be embedded into message) - service.ResponseMetaHeader Meta = 99; } message DeleteRequest { // Address of object (container id + object id) @@ -117,8 +112,6 @@ message DeleteRequest { // DeleteResponse is empty because we cannot guarantee permanent object removal // in distributed system. message DeleteResponse { - // ResponseMetaHeader contains meta information based on request processing by server (should be embedded into message) - service.ResponseMetaHeader Meta = 99; } message HeadRequest { @@ -138,8 +131,6 @@ message HeadRequest { message HeadResponse { // Object without payload Object Object = 1; - // ResponseMetaHeader contains meta information based on request processing by server (should be embedded into message) - service.ResponseMetaHeader Meta = 99; } message SearchRequest { @@ -176,8 +167,6 @@ message SearchRequest { message SearchResponse { // Addresses of found objects repeated refs.Address Addresses = 1; - // ResponseMetaHeader contains meta information based on request processing by server (should be embedded into message) - service.ResponseMetaHeader Meta = 99; } message Range { @@ -201,8 +190,6 @@ message GetRangeRequest { message GetRangeResponse { // Fragment of object's payload bytes Fragment = 1; - // ResponseMetaHeader contains meta information based on request processing by server (should be embedded into message) - service.ResponseMetaHeader Meta = 99; } message GetRangeHashRequest { @@ -221,7 +208,5 @@ message GetRangeHashRequest { message GetRangeHashResponse { // Hashes is a homomorphic hashes of all ranges repeated bytes Hashes = 1; - // ResponseMetaHeader contains meta information based on request processing by server (should be embedded into message) - service.ResponseMetaHeader Meta = 99; } diff --git a/proto-docs/object.md b/proto-docs/object.md index ce800fc..df6833a 100644 --- a/proto-docs/object.md +++ b/proto-docs/object.md @@ -161,10 +161,6 @@ DeleteResponse is empty because we cannot guarantee permanent object removal in distributed system. -| Field | Type | Label | Description | -| ----- | ---- | ----- | ----------- | -| Meta | [service.ResponseMetaHeader](#service.ResponseMetaHeader) | | ResponseMetaHeader contains meta information based on request processing by server (should be embedded into message) | - @@ -190,7 +186,6 @@ in distributed system. | Field | Type | Label | Description | | ----- | ---- | ----- | ----------- | | Hashes | [bytes](#bytes) | repeated | Hashes is a homomorphic hashes of all ranges | -| Meta | [service.ResponseMetaHeader](#service.ResponseMetaHeader) | | ResponseMetaHeader contains meta information based on request processing by server (should be embedded into message) | @@ -216,7 +211,6 @@ in distributed system. | Field | Type | Label | Description | | ----- | ---- | ----- | ----------- | | Fragment | [bytes](#bytes) | | Fragment of object's payload | -| Meta | [service.ResponseMetaHeader](#service.ResponseMetaHeader) | | ResponseMetaHeader contains meta information based on request processing by server (should be embedded into message) | @@ -243,7 +237,6 @@ in distributed system. | ----- | ---- | ----- | ----------- | | object | [Object](#object.Object) | | Object header and some payload | | Chunk | [bytes](#bytes) | | Chunk of remaining payload | -| Meta | [service.ResponseMetaHeader](#service.ResponseMetaHeader) | | ResponseMetaHeader contains meta information based on request processing by server (should be embedded into message) | @@ -270,7 +263,6 @@ in distributed system. | Field | Type | Label | Description | | ----- | ---- | ----- | ----------- | | Object | [Object](#object.Object) | | Object without payload | -| Meta | [service.ResponseMetaHeader](#service.ResponseMetaHeader) | | ResponseMetaHeader contains meta information based on request processing by server (should be embedded into message) | @@ -308,7 +300,6 @@ in distributed system. | Field | Type | Label | Description | | ----- | ---- | ----- | ----------- | | Address | [refs.Address](#refs.Address) | | Address of object (container id + object id) | -| Meta | [service.ResponseMetaHeader](#service.ResponseMetaHeader) | | ResponseMetaHeader contains meta information based on request processing by server (should be embedded into message) | @@ -371,7 +362,6 @@ in distributed system. | Field | Type | Label | Description | | ----- | ---- | ----- | ----------- | | Addresses | [refs.Address](#refs.Address) | repeated | Addresses of found objects | -| Meta | [service.ResponseMetaHeader](#service.ResponseMetaHeader) | | ResponseMetaHeader contains meta information based on request processing by server (should be embedded into message) | diff --git a/proto-docs/service.md b/proto-docs/service.md index 961f38e..8cad084 100644 --- a/proto-docs/service.md +++ b/proto-docs/service.md @@ -9,7 +9,6 @@ - [RequestExtendedHeader](#service.RequestExtendedHeader) - [RequestExtendedHeader.KV](#service.RequestExtendedHeader.KV) - [RequestMetaHeader](#service.RequestMetaHeader) - - [ResponseMetaHeader](#service.ResponseMetaHeader) - [service/verify.proto](#service/verify.proto) @@ -74,19 +73,6 @@ RequestMetaHeader contains information about request meta headers | Version | [uint32](#uint32) | | Version defines protocol version TODO: not used for now, should be implemented in future | | ExtendedHeader | [RequestExtendedHeader](#service.RequestExtendedHeader) | | ExtendedHeader carries extended headers of the request | - - - -### Message ResponseMetaHeader -ResponseMetaHeader contains meta information based on request processing by server -(should be embedded into message) - - -| Field | Type | Label | Description | -| ----- | ---- | ----- | ----------- | -| Epoch | [uint64](#uint64) | | Current NeoFS epoch on server | -| Version | [uint32](#uint32) | | Version defines protocol version TODO: not used for now, should be implemented in future | - diff --git a/service/meta.proto b/service/meta.proto index 768fc75..41e3776 100644 --- a/service/meta.proto +++ b/service/meta.proto @@ -17,16 +17,6 @@ message RequestMetaHeader { RequestExtendedHeader ExtendedHeader = 5; } -// ResponseMetaHeader contains meta information based on request processing by server -// (should be embedded into message) -message ResponseMetaHeader { - // Current NeoFS epoch on server - uint64 Epoch = 1; - // Version defines protocol version - // TODO: not used for now, should be implemented in future - uint32 Version = 2; -} - // RequestExtendedHeader contains extended headers of request message RequestExtendedHeader { // KV contains string key-value pair