From b5235bdf34d355ba6f6292a37611bea1e70ca511 Mon Sep 17 00:00:00 2001 From: Denis Kirillov Date: Wed, 29 Dec 2021 11:05:21 +0300 Subject: [PATCH] [#106] Add stringer and tests Signed-off-by: Denis Kirillov --- acl/types.go | 6 ++++ acl/types_test.go | 82 +++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 88 insertions(+) create mode 100644 acl/types_test.go diff --git a/acl/types.go b/acl/types.go index 00cd953..1cb2217 100644 --- a/acl/types.go +++ b/acl/types.go @@ -6,6 +6,12 @@ import ( "strings" ) +type BasicACL uint32 + +func (a BasicACL) String() string { + return fmt.Sprintf("0x%x", uint32(a)) +} + const ( // PublicBasicRule is a basic ACL value for final public-read-write container for which extended ACL CANNOT be set. PublicBasicRule = 0x1FBFBFFF diff --git a/acl/types_test.go b/acl/types_test.go new file mode 100644 index 0000000..8969a22 --- /dev/null +++ b/acl/types_test.go @@ -0,0 +1,82 @@ +package acl + +import ( + "testing" + + "github.com/stretchr/testify/require" +) + +func TestParser(t *testing.T) { + for _, tc := range []struct { + acl string + expected uint32 + err bool + }{ + { + acl: PublicBasicName, + expected: PublicBasicRule, + }, + { + acl: PrivateBasicName, + expected: PrivateBasicRule, + }, + { + acl: ReadOnlyBasicName, + expected: ReadOnlyBasicRule, + }, + { + acl: PublicAppendName, + expected: PublicAppendRule, + }, + { + acl: EACLPublicBasicName, + expected: EACLPublicBasicRule, + }, + { + acl: EACLPrivateBasicName, + expected: EACLPrivateBasicRule, + }, + { + acl: EACLReadOnlyBasicName, + expected: EACLReadOnlyBasicRule, + }, + { + acl: EACLPublicAppendName, + expected: EACLPublicAppendRule, + }, + { + acl: "0x1C8C8CCC", + expected: 0x1C8C8CCC, + }, + { + acl: "1C8C8CCC", + expected: 0x1C8C8CCC, + }, + { + acl: "123456789", + err: true, + }, + { + acl: "0x1C8C8CCG", + err: true, + }, + } { + actual, err := ParseBasicACL(tc.acl) + if tc.err { + require.Error(t, err) + continue + } + + require.NoError(t, err) + require.Equal(t, tc.expected, actual) + } +} + +func TestString(t *testing.T) { + acl := BasicACL(0x1fbfbfff) + require.Equal(t, "0x1fbfbfff", acl.String()) + + acl2, err := ParseBasicACL(PrivateBasicName) + require.NoError(t, err) + require.Equal(t, "0x1c8c8ccc", BasicACL(acl2).String()) +}