carpawell/frostfs-sdk-go
1
0
Fork 0
forked from TrueCloudLab/frostfs-sdk-go
Code Issues Pull requests Projects Releases Packages Wiki Activity

pool: Replace IsErrXXX functions with errors

Browse source 
Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
This commit is contained in:
Evgenii Baidakov 2023-05-05 10:13:27 +04:00
parent 7d2cfff825
commit f1b438a2ac
No known key found for this signature in database
GPG key ID: 8733EE3D72CDB4DE
2 changed files with 7 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
client/client.go
View file

@ -31,14 +31,13 @@ import (
// Each method which produces a NeoFS API call may return a server response. // Each method which produces a NeoFS API call may return a server response.
// Status responses are returned in the result structure, and can be cast // Status responses are returned in the result structure, and can be cast
// to built-in error instance (or in the returned error if the client is // to built-in error instance (or in the returned error if the client is
// configured accordingly). Certain statuses can be checked using `apistatus` // configured accordingly). Certain statuses can be checked using [apistatus]
// and standard `errors` packages. Note that package provides some helper // and standard [errors] packages.
// functions to work with status returns (e.g. IsErrContainerNotFound).
// All possible responses are documented in methods, however, some may be // All possible responses are documented in methods, however, some may be
// returned from all of them (pay attention to the presence of the pointer sign): // returned from all of them (pay attention to the presence of the pointer sign):
// - *apistatus.ServerInternal on internal server error; // - *[apistatus.ServerInternal] on internal server error;
// - *apistatus.NodeUnderMaintenance if a server is under maintenance; // - *[apistatus.NodeUnderMaintenance] if a server is under maintenance;
// - *apistatus.SuccessDefaultV2 on default success. // - *[apistatus.SuccessDefaultV2] on default success.
// //
// Client MUST NOT be copied by value: use pointer to Client instead. // Client MUST NOT be copied by value: use pointer to Client instead.
// //

6
pool/pool.go
View file

@ -1527,8 +1527,6 @@ type resCreateSession struct {
// Each method which produces a NeoFS API call may return an error. // Each method which produces a NeoFS API call may return an error.
// Status of underlying server response is casted to built-in error instance. // Status of underlying server response is casted to built-in error instance.
// Certain statuses can be checked using `sdkClient` and standard `errors` packages. // Certain statuses can be checked using `sdkClient` and standard `errors` packages.
// Note that package provides some helper functions to work with status returns
// (e.g. sdkClient.IsErrContainerNotFound, sdkClient.IsErrObjectNotFound).
// //
// See pool package overview to get some examples. // See pool package overview to get some examples.
type Pool struct { type Pool struct {
@ -1860,7 +1858,7 @@ func (p *Pool) checkSessionTokenErr(err error, address string) bool {
return false return false
} }
if sdkClient.IsErrSessionNotFound(err) || sdkClient.IsErrSessionExpired(err) { if errors.Is(err, apistatus.ErrSessionTokenNotFound) || errors.Is(err, apistatus.ErrSessionTokenExpired) {
p.cache.DeleteByPrefix(address) p.cache.DeleteByPrefix(address)
return true return true
} }
@ -2458,7 +2456,7 @@ func waitForContainerRemoved(ctx context.Context, cli client, cnrID *cid.ID, wai
return waitFor(ctx, waitParams, func(ctx context.Context) bool { return waitFor(ctx, waitParams, func(ctx context.Context) bool {
_, err := cli.containerGet(ctx, prm) _, err := cli.containerGet(ctx, prm)
return sdkClient.IsErrContainerNotFound(err) return errors.Is(err, apistatus.ErrContainerNotFound)
}) })
} }