From 1fe7f7b2faf02483eed1a2f52bd1c57d7b410fe2 Mon Sep 17 00:00:00 2001
From: Evgeniy Kulikov <kim@nspcc.ru>
Date: Wed, 5 Feb 2020 13:42:49 +0300
Subject: [PATCH] make object.GetRange to be server-side streaming RPC

---
 docs/object.md       |   9 +++++----
 object/service.pb.go | Bin 122795 -> 123088 bytes
 object/service.proto |  11 ++++++-----
 3 files changed, 11 insertions(+), 9 deletions(-)

diff --git a/docs/object.md b/docs/object.md
index dbdd6dc..997991a 100644
--- a/docs/object.md
+++ b/docs/object.md
@@ -64,7 +64,7 @@ rpc Put(stream PutRequest) returns (PutResponse);
 rpc Delete(DeleteRequest) returns (DeleteResponse);
 rpc Head(HeadRequest) returns (HeadResponse);
 rpc Search(SearchRequest) returns (stream SearchResponse);
-rpc GetRange(GetRangeRequest) returns (GetRangeResponse);
+rpc GetRange(GetRangeRequest) returns (stream GetRangeResponse);
 rpc GetRangeHash(GetRangeHashRequest) returns (GetRangeHashResponse);
 
 ```
@@ -119,8 +119,9 @@ package).
 | Search | [SearchRequest](#object.SearchRequest) | [SearchResponse](#object.SearchResponse) |
 #### Method GetRange
 
-GetRange of data payload. Ranges are set of pairs (offset, length).
-Fragments order in response corresponds to ranges order in request.
+GetRange of data payload. Range is a pair (offset, length).
+Requested range can be restored by concatenation of all chunks
+keeping receiving order.
 
 | Name | Input | Output |
 | ---- | ----- | ------ |
@@ -196,7 +197,7 @@ in distributed system.
 | Field | Type | Label | Description |
 | ----- | ---- | ----- | ----------- |
 | Address | [refs.Address](#refs.Address) |  | Address of object (container id + object id) |
-| Ranges | [Range](#object.Range) | repeated | Ranges of object's payload to return |
+| Range | [Range](#object.Range) |  | Range of object's payload to return |
 | Meta | [service.RequestMetaHeader](#service.RequestMetaHeader) |  | RequestMetaHeader contains information about request meta headers (should be embedded into message) |
 | Verify | [service.RequestVerificationHeader](#service.RequestVerificationHeader) |  | RequestVerificationHeader is a set of signatures of every NeoFS Node that processed request (should be embedded into message) |
 
diff --git a/object/service.pb.go b/object/service.pb.go
index 05e7c4b370689e275c5b1a56b1029b1b432003f8..0e40508d44a3d7fbbaffdeba7cf9aa903ba924ca 100644
GIT binary patch
delta 5870
zcmbW5TZ~;*8OL)<OFL7>q4XkPGwhU$Eg9`Td!N0}-X_F{nvmdwIs}j!srw48W!j#Z
z)<XzxeK6WYQ{&Q{7#JvtHBo3aInlvLTPM7lP<>PkK1($5)l1@9|KFmWXJ6LrS-0=@
z|Nh^%&KuXa-`Lpx%cD!?OG^)K3zmxIXHB?k;U4$VES?^nT0IpX2u`e=TK?1l%}qC!
zF5G_G!9#(0=Gl+$o}GDVc4pM9o*gagZ1dtv)9*dKc=whhH@`iz(pB|h5RTKvjZNvs
z!C-NACLH$%?w?8vmA<pw&D7eIYd+50OsOmCzWa`~GpXEn6uB{p-B=`U%ry=Z2^hEo
z-B^Fdk!~93){<|HoXeOg+#P&Jl9OttmV{7uGn40%kfgVSrlI?8hHgad+#T!2*oNMv
z?#OiCuytD#NoX}6%ECmtl(8hFTBzh0j<u2#YOLj$NZ;0Ir@VG@MdD28yycNRHq<h5
ztc5NNv1~{sbSU@qwUsbLNFV@`GthUVospD}Wlk+~S_vSia#Cl5qWdbXv#YONeFeI}
z#k#MN1m<ycCVv)^nQ67v{#^4}L!h+`(5z4w1_{foORW69?j}|Q5t)hZ7)rZXw}u)C
zNuyxcz&Iym+7!xFpso=1QkhP829n7PCOAJ^`JvPcb)Z6~j@b}fRed%j(z}#ULJ4jM
zY?7-|T~RC0eNci6h1F7K5{wcjS$(a18(U|?P&YNQB-052)Gb>zfN!mHwQd?nPAUoh
zlnfyo`|<_h35OCuf|5Q2pv@LL2TJWN<eyNI0j^!PtAGJadgv+8xyD*!+Dbws6Z%pT
z6G-Jy&WogKju-$il>Aus5Qa=X<O-}EU`dS)T85`eBBr}rT~SK;NHdi}1)+eIMi;?!
z=rTY)aSH)!p_{<+KoSatq>%Pt&*!0LVuit@SCSJ#qO*xY0=ZcvyEt#gO;L8v#pF2I
zRqGA_g6q*Wl06|HmeT<v&hx~T;v~6&5TiV<N~BT=#5E?!2NRyTWNl4CDV~rYDHa1I
zf0LHsEZjDflChM80<4Q2hU5k)izH^IYGwaW%ZaSA3FW**u)slqu3BznL!$#=m5hSE
zz!2^x&;*iNmPoG>Cz0K0N4N!9XbgL(3e*57EmmM)mj=fuKO*v7J}-edCRAFEr7CsD
z*ILcDn(udVbYFhMKbADD$Dktu1DD{{M$&9HiuSa%kTQ-;Ex2SzEHw%_EMrEdQ;9$_
z?x{K@MS=~w$mW5)$b#5OAXrRsD})EEU~c9iR?rLiHe`b&lZ_;_4<VG%@n5SD52P_3
z8%l37Fjmk#v2SvHf0OH>cgW9EX(1C@9ZqE@o}@$))vne;19L!lFo#C6&R0b_CMVFu
zHrgbi(1BL*^cf&kNn)-52J9roI-*CD<Y^Cu<q^vRE)1=N`ZPiGCYl)PK%p5BTVsgi
zS6UsCLo%V1n_>6P(!P`6*P%2VAWH}jwWiihH~_EO;^?p<IRnm0j_+d>9_wHy0DM4x
z)P}+xw*40f6ih<t4TvEeAO;0O@2%uS>=#IE6XYb2<dh|l1Y(FV9P5>rNO`^+dzi`+
zS|QI((uJaF%ZQTz_FK7!!iQqE{8=~9RWa`y9636Yv|Oq}iZm)Rq#I{CZ0og?fR<D<
z?_6?%Oqb+b_aPJ1_ctMi7TY%%Iz_W%E0+@hyMTbudeZhEgm|c1shtDBg)}*aelpbz
z3M+bJh|pJgBvgtz@u4ATWIF8YWLm^vv%SvBr;fo8c*b|T0w5)YCcq|uv%%K}5h!&>
zt@N1QGL^zu$m;=Q0t0B0lIGO5@?i@sw+tmOk$juN2Ppw7FGo%SP_&I8nWh_8k^AJN
ze+JO(VXft0*MHG4RPqeigFiS2Br>hWatTcZU7)W=@;Mo8gXc`ZZ`9OW`0x)TB`ct}
z^G-g^1FXbWUPHb~B8w&8H+3}K(2?iHO(906?G)_Q<fL!L<uD#@w39Z)oqXSnN=f2o
z>!GuO!VmdToN0qS`N$cWVBlLw1&j<J(|p@3n+qj0F0?u61muzW53tPMkXvPRU*~AC
z;by3o2WKjKJeLX3$OMv>-kk*hxB-*8j$$^DGHoLHiSjg4c2)9Zt89dD$#gnT+9@6e
z_PyyO(0bB5@{07RQ^aU9C^GaEzMWKf8tf;1e9tGzv>CQ}auRqSP&+|7Z2_UAp^sz&
zHI-x~m2qK2KFJI8I-otyIwa^cT_xJ{W<ysVfBqFGzftBrTgzco4l;%i@`$uKE++{k
zFgNKI%iB?>KdmBz_AovSMUL@`>H}!)#9;u&lCP6M0DPg8v|8qZPx>WZv~-?yX9M~_
zp5^qj+>Ls8-dZjjARLX*D4gXRQwTz%&lPC_J|Pr-q2Ph)e}m|xr0rUq1Zn`agN_Uv
zpaW>!zcl0w5R1+JTkfF-f?g_=<sK)XRGL7z;HJx^F%J~~SOH41leV6&AyKH<L%?7$
zy6O@WsBbj4bX&aEArVk#w_4U=XUAI(EoxZ>0C;JkF!NSzg+Vs3z%g(G)%l-!<OW|S
zASfKB5nV93Bh!Gse@1f?PA8Py1np4lX?^X>-daM%X{o7VQL?^KuE4JRAZ15q0{`g1
z$Htr^XZfa5HTm?9-@3G8HaNZ#6v64@_{hv(`sn;pbLMQbvf9+a$o&9mj$M54BgM&+
zLG|3(<*%;H&Ky2$zHolQ{Na_y%rDOG+^JtAkDNT-EU!*~c4=?V{AaD6zWx1UcevGU
zS~ai#@bNA2mrei2yG^&Y)0nl;eELUoJ05LTSucL@&Q|wj{`u{_CNpzpcwwJ;(mddg
zzxQ&w_rtwNIutB5)wzS_@P+;6E3a-ff3{~HU7I)iCugSrSexJe|JgJzZ4N&Cp)7Ob
z;vTQU?|*Xd^xCB-wmm#*&IC6%cvme3E2DG4<IU*Y@v1p?^Yr<jADNmr4%}frxN^UF
z?DCvR-@4nJxcoVO*gg3CV(`!kXKo((`mcjqUiskif_dunoY{3{(QEO@m3)_Ubh4V!
zAuDsaHXBFxnJ=y%nf~`TuiZBN+tu&%%<T1jx31Z^wqVw;?lIrJwtqUhKAW3&Huh{)
zWWRaifcf3uzh<6!|F6?;{Og`z=gHua;Q3EV!sN9*y-!Tup6Sg^?wjlV$^7NtcTL{h
z-TTbs;(fi_*FV3%_p1x*8^?NgZb7xl>nD1}`n}Kfu5O<!{IoY~-aWcw{e@S1@AoF}
TzSX;H^4X_)Pp{jr_a6EmYRneZ

delta 5484
zcmai&%d1sY9LG6V>E3hHBJ+tvhY-pV-S52*G-*&04WtXw3zPj62O0MvoJKnXYpAdW
zSDIJ@Nzp_&*`<fv928NL{)%eUteHY<eLqXPvnKoQyY^bY$M^U9eSg1oe!n+=V`KjI
zJBw!N)cz-z+tqW+XGg=u^6cq$W&G|*^U>md^UJ9hXMerY&Y6vOMrQoh{H!>!bE{cA
z{j$0J#uKy8-rm1&F3HTDrIkKu4v&Lr(z$0GyJwmn9u0$On7Du1R!?o3Xe9{UN}}~L
zckfm0p0)OrsaEtg&fI$>q0z*>XOd7vQc$|j{j}DuTwl`C?TXQ$XCc{D;nu4_GSH*<
zNM8dzbM1+ADoUiGlDJ9bj$v>nKO3z~+}3^?NA7bfD_i*!=)Kl@paZ$IwbI<k-U%R8
z`drKSkaumxsY2^Ol5cV<k-@1G*H0@M6H7CjGHhw(L(K<C%A`7xhLopZP33y3ow1DU
zc;~C^V!h^F`mM90VQ&McU?H_u_*$8iYj47eq!NG-snXx!vv98DVX3dNo}C8?+yF+t
zl{(;5TK#sH3$EZM4+~kJNFF&!icKW7VW-5|pu1cpd&q`X8XBGgCV!+Ym=;>EG2SY$
z`WvB<=~?PSsrQDYtEHhNlrky8V7(`jO_nO4(^Tt?fB~uofDtD-WO!~JarjdX#J=IX
z0LX+}D@nlPVFdssLn_%5ywbDNsZ82xJuRpXq)uMpdZbNZc(}LFXOh9^LMH;j5NJIU
z=!w=_JsVkP58JbW1SPltl7$Yp0*QDAIzU-X<W4{)qd(MEye%b_h=B+kW0}MG;9-yq
z4iEq`lK^<KkYR+OmglPXX^evuaW4N!G|L=L1Ld8|q?kZUTcP(>;f_=vR5v*Z`9Kzd
z_TXnjGLTgzVUX%vs8(6;KqLTg2HZg4Knd#sy(FzA0-QT(gPJUm&V^K;F%|yK70FPC
ziQ7agMJWAH5V_BXPFn$nVuj2te>e>Q6G}#lKg!9H!02!)kccNWS;^;uJu<s4q(4=B
z*ksAvX(;qPCvbXZq?Oi@L??o>2-t)@s-YSZBLK1yXl+)>1#K#NS<{i@dXMx>l(JMk
z#17RLk_4qgoFtU1W!vkJ1}VidhL*NjDBZ%dWv?`)-Xh5$4Se4LF$to^eO=QVV8TdY
zC@D~h;4nEv^uo<xD3fiAv<4Tw{2__akB6SRL#d`FXp!`h5I|-8L?P*9MIhPmC-BfA
zu#q%`4J^^QF!V${6Woz}U|_(vLUvdBnkkg6AfYBU=Peot6)xC{bs7>KXf~M|DxYBS
zo;J^T;^|E~=|Mn(b%}hA<tL+%?T}7GB=eXfeD{%vnCunMj3V?Y%a#`UL{-vLzbx6I
z!hWbgQX*^;I}Hp0Pymk7G^r(I+o{SP?gU{cQ=uv9lQ59ygn`D|Tde*=i6%&DU?0FR
zHZW&ZGLnf1N}X&94~-=vJ><C^RGfm0ED<DyA}PMH^Pemx3`{;g10{pBVg)Xt2hvPJ
zkfh!a)JP9tw0xGfSjLd(G&!~9eu^=kf|Mm}W&Wjbt42O_K&&E9l~zQLzSF2ysP2y1
z*M5kL05G-TtO~uK(%%DopqtV17zNM?zx#$Lsnl4ecRwS-*?K~LP(9RSx!i>TKgl6C
z+S&Po0+|SIst$;0AQNe*gdWw!oayNp6r|Il>NEfe^DJr2fdmms0NS<VZ>v94#5e$F
zFhi1bXs)HfM$c)8bb#FRIVt1G$r^Eb`hk^fgxytKxSZP(bNY#=Hd$hK8fd)G5nZ!T
zW)KVl<B46>z|048bH%XnwAILT2Gw)vuvF?4_?R$%kYg|uw<yMUMsfxzXpauYL{^dp
zRHIN$A0q5Dz$MHdP!pH0mfF)+Tgq<!^NpX<)Dz}F4|X$bG}2~k&uQ=@u7LKVuS_D6
zln>EE5VS(mW?;5ZIsKsOW2N}m0&p5SS?M!f6~&O6Dq<Y)cPx2D0>Cu>UMq`8_ZVJR
zAni_tq0;;TCiE04&6A(pO*p3v1VchhPX+W`*+UI6y4VYdKq6NGiQET68CG=C?`w?C
zBKsf(24ik_^c}x~4^(s@^JqwzO+i5o^g6hn>4=$%3suYf#eI*<iXW1Myd5^258SD7
z4hn*InSw|zT%Z%s<@^ePk^hVi<Pg-<wY@YjW_T!df@uo^C!u&J4+#~Xb2H(x%H0QP
z46+tT=K{Rzsa^{FEu~lQVtQo2$+f~ogZiySa<mlR<rPB)72n?&Lzx$7f3|7Z<mLbr
zm@4RgYE#&%UVoUI>768WtQ5y!|69WZN>OB}1AY(SvP8@G*GFX%{0-c62rhIDoULcj
zOQ<bVhZ6NhveZI}Oeb*EEcp@WG#3qcfWaff9YF|vqTjZ0DUddbg~L55>p@qIk-oGM
zn1ikC^uM^Ml&Ey3HaiO{(83KfxFvXY)jB@{<q8aC+A}=iE$CIMWvZJo1B9(7P6OHP
zf98;*^dQV;R7McSqsQN8q#0@^V|N!ql99|#4NgOro4=R#jQz+a!@0(B<0Y|^aCYF6
zs|)7SYX|p^hDVQ%UtKOwzu%r+T^WC{+_cN%GiS}lwa~nD@wj<#X=pyax_fr(;%__j
z&yQDjnd6tY%^z!5-S39x)a7)+zqjVd7sqF>eg541|A`)rhL6sK*AMJmY?scpE31db
z&%f|c?)j^GtkQ+SEWUnXt2uUYw|Vo{j(NY)e0^nX-n*I4{`u<J?PmKA7tHJ5?K1s0
zrMdCl(Coe2ne%r)eCqjnb$WQb+%6s2B=*khvp>H7a*K)Y?KC?!hUVtRf_d=mf;qTx
zV0K~S(qMM}-e|IRYRh1_et*kg%bfY~<Y;!}{``3Dv1bO;wSC(Lf12_A$Jfs69K5{t
gU~ISDetK}{;`*VV2Dj(d@BTXYd4B!#^+9mxUw1B*6951J

diff --git a/object/service.proto b/object/service.proto
index 4487a49..fb80e5d 100644
--- a/object/service.proto
+++ b/object/service.proto
@@ -42,9 +42,10 @@ service Service {
     // package).
     rpc Search(SearchRequest) returns (stream SearchResponse);
 
-    // GetRange of data payload. Ranges are set of pairs (offset, length).
-    // Fragments order in response corresponds to ranges order in request.
-    rpc GetRange(GetRangeRequest) returns (GetRangeResponse);
+    // GetRange of data payload. Range is a pair (offset, length).
+    // Requested range can be restored by concatenation of all chunks
+    // keeping receiving order.
+    rpc GetRange(GetRangeRequest) returns (stream GetRangeResponse);
 
     // GetRangeHash returns homomorphic hash of object payload range after XOR
     // operation. Ranges are set of pairs (offset, length). Hashes order in
@@ -153,8 +154,8 @@ message SearchResponse {
 message GetRangeRequest {
     // Address of object (container id + object id)
     refs.Address Address                     = 1 [(gogoproto.nullable) = false];
-    // Ranges of object's payload to return
-    repeated Range Ranges                    = 2 [(gogoproto.nullable) = false];
+    // Range of object's payload to return
+    Range Range                              = 2 [(gogoproto.nullable) = false];
     // RequestMetaHeader contains information about request meta headers (should be embedded into message)
     service.RequestMetaHeader Meta           = 98 [(gogoproto.embed) = true, (gogoproto.nullable) = false];
     // RequestVerificationHeader is a set of signatures of every NeoFS Node that processed request (should be embedded into message)