From 188206eeded75367c2a58a2553a0e8325e76aba9 Mon Sep 17 00:00:00 2001 From: Mary Anthony Date: Thu, 24 Mar 2016 15:59:26 -0700 Subject: [PATCH 1/2] Fixes and closes #925 Seconds to minutes as per code Correction per Derek Clarifying failure case Signed-off-by: Mary Anthony Clarifying failure case Signed-off-by: Mary Anthony --- docs/configuration.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/configuration.md b/docs/configuration.md index ae895097..2ff0f324 100644 --- a/docs/configuration.md +++ b/docs/configuration.md @@ -164,7 +164,7 @@ information about each option that appears later in this page. baseurl: https://my.cloudfronted.domain.com/ privatekey: /path/to/pem keypairid: cloudfrontkeypairid - duration: 3000 + duration: 3000s reporting: bugsnag: apikey: bugsnagapikey @@ -694,7 +694,7 @@ in the registry implementation. baseurl: https://my.cloudfronted.domain.com/ privatekey: /path/to/pem keypairid: cloudfrontkeypairid - duration: 3000 + duration: 3000s Each middleware entry has `name` and `options` entries. The `name` must correspond to the name under which the middleware registers itself. The @@ -753,7 +753,7 @@ interpretation of the options. no - Duration for which a signed URL should be valid. + Specify a `duration` by providing an integer and a unit. Valid time units are `ns`, `us` (or `µs`), `ms`, `s`, `m`, `h`. For example, `3m` is a valid duration. If you do not specify a `duration` or specify an integer without a time unit, this defaults to 20 minutes. From 6018bdf58a15321ce0e1a973053351d9ac50a643 Mon Sep 17 00:00:00 2001 From: Mary Anthony Date: Tue, 29 Mar 2016 09:53:13 -0700 Subject: [PATCH 2/2] Updating example Signed-off-by: Mary Anthony --- docs/configuration.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/configuration.md b/docs/configuration.md index 2ff0f324..f9b89feb 100644 --- a/docs/configuration.md +++ b/docs/configuration.md @@ -753,7 +753,7 @@ interpretation of the options. no - Specify a `duration` by providing an integer and a unit. Valid time units are `ns`, `us` (or `µs`), `ms`, `s`, `m`, `h`. For example, `3m` is a valid duration. If you do not specify a `duration` or specify an integer without a time unit, this defaults to 20 minutes. + Specify a `duration` by providing an integer and a unit. Valid time units are `ns`, `us` (or `µs`), `ms`, `s`, `m`, `h`. For example, `3000s` is a valid duration; there should be no space between the integer and unit. If you do not specify a `duration` or specify an integer without a time unit, this defaults to 20 minutes.