From f09051fe54aa61cdac98fa347057c2766e15abf4 Mon Sep 17 00:00:00 2001 From: Jon Poler Date: Mon, 22 Jun 2015 20:59:28 -0700 Subject: [PATCH] Remove timeout for http.Client in registry/client/repository.go. Timeouts should not be a discrete period of time, because they end up being arbitrary and may be difficult to gauge correctly against very large Docker layers. Rather, timeouts should be set at the transport level using the SetDeadline attribute on a net.Conn object. Signed-off-by: Jon Poler --- registry/client/repository.go | 1 - 1 file changed, 1 deletion(-) diff --git a/registry/client/repository.go b/registry/client/repository.go index 807ce9a6..4a66f70b 100644 --- a/registry/client/repository.go +++ b/registry/client/repository.go @@ -34,7 +34,6 @@ func NewRepository(ctx context.Context, name, baseURL string, transport http.Rou client := &http.Client{ Transport: transport, - Timeout: 1 * time.Minute, // TODO(dmcgowan): create cookie jar }