dkirillov/distribution
1
0
Fork 0
forked from TrueCloudLab/distribution
Code Pull requests Activity

Remove timeout for http.Client in registry/client/repository.go.

Browse source 
Timeouts should not be a discrete period of time, because they end
up being arbitrary and may be difficult to gauge correctly against
very large Docker layers. Rather, timeouts should be set at the
transport level using the SetDeadline attribute on a net.Conn
object.

Signed-off-by: Jon Poler <jonathan.poler@apcera.com>
This commit is contained in:
Jon Poler 2015-06-22 20:59:28 -07:00
parent dc19b5496a
commit 855ecb8440
1 changed files with 0 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
docs/client/repository.go
View file

@ -34,7 +34,6 @@ func NewRepository(ctx context.Context, name, baseURL string, transport http.Rou
client := &http.Client{ client := &http.Client{
Transport: transport, Transport: transport,
Timeout: 1 * time.Minute,
// TODO(dmcgowan): create cookie jar // TODO(dmcgowan): create cookie jar
} }