forked from TrueCloudLab/distribution
58d239d723
Under certain circumstances, the use of `StorageDriver.GetContent` can
result in unbounded memory allocations. In particualr, this happens when
accessing a layer through the manifests endpoint.
This problem is mitigated by setting a 4MB limit when using to access
content that may have been accepted from a user. In practice, this means
setting the limit with the use of `BlobProvider.Get` by wrapping
`StorageDriver.GetContent` in a helper that uses `StorageDriver.Reader`
with a `limitReader` that returns an error.
When mitigating this security issue, we also noticed that the size of
manifests uploaded to the registry is also unlimited. We apply similar
logic to the request body of payloads that are full buffered.
Signed-off-by: Stephen J Day <stephen.day@docker.com>
(cherry picked from commit
|
||
|---|---|---|
| .. | ||
| api_test.go | ||
| app.go | ||
| app_test.go | ||
| basicauth.go | ||
| basicauth_prego14.go | ||
| blob.go | ||
| blobupload.go | ||
| catalog.go | ||
| context.go | ||
| health_test.go | ||
| helpers.go | ||
| hmac.go | ||
| hmac_test.go | ||
| hooks.go | ||
| images.go | ||
| mail.go | ||
| tags.go | ||