forked from TrueCloudLab/distribution
31047c8113
The current implementation of digest.FromBytes returns an error. This error can never be non-nil, but its presence in the function signature means each call site needs error handling code for an error that is always nil. I verified that none of the hash.Hash implementations in the standard library can return an error on Write. Nor can any of the hash.Hash implementations vendored in distribution. This commit changes digest.FromBytes not to return an error. If Write returns an error, it will panic, but as discussed above, this should never happen. This commit also avoids using a bytes.Reader to feed data into the hash function in FromBytes. This makes the hypothetical case that would panic a bit more explicit, and should also be more performant. Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com> |
||
|---|---|---|
| .. | ||
| cache | ||
| driver | ||
| blob_test.go | ||
| blobcachemetrics.go | ||
| blobserver.go | ||
| blobstore.go | ||
| blobwriter.go | ||
| blobwriter_nonresumable.go | ||
| blobwriter_resumable.go | ||
| catalog.go | ||
| catalog_test.go | ||
| doc.go | ||
| filereader.go | ||
| filereader_test.go | ||
| filewriter.go | ||
| filewriter_test.go | ||
| linkedblobstore.go | ||
| manifeststore.go | ||
| manifeststore_test.go | ||
| paths.go | ||
| paths_test.go | ||
| purgeuploads.go | ||
| purgeuploads_test.go | ||
| registry.go | ||
| revisionstore.go | ||
| signaturestore.go | ||
| tagstore.go | ||
| util.go | ||
| vacuum.go | ||
| walk.go | ||
| walk_test.go | ||