forked from TrueCloudLab/distribution
cb6f002350
Add a generic Manifest interface to represent manifests in the registry and remove references to schema specific manifests. Add a ManifestBuilder to construct Manifest objects. Concrete manifest builders will exist for each manifest type and implementations will contain manifest specific data used to build a manifest. Remove Signatures() from Repository interface. Signatures are relevant only to schema1 manifests. Move access to the signature store inside the schema1 manifestStore. Add some API tests to verify signature roundtripping. schema1 ------- Change the way data is stored in schema1.Manifest to enable Payload() to be used to return complete Manifest JSON from the HTTP handler without knowledge of the schema1 protocol. tags ---- Move tag functionality to a seperate TagService and update ManifestService to use the new interfaces. Implement a driver based tagService to be backward compatible with the current tag service. Add a proxyTagService to enable the registry to get a digest for remote manifests from a tag. manifest store -------------- Remove revision store and move all signing functionality into the signed manifeststore. manifest registration --------------------- Add a mechanism to register manifest media types and to allow different manifest types to be Unmarshalled correctly. client ------ Add ManifestServiceOptions to client functions to allow tags to be passed into Put and Get for building correct registry URLs. Change functional arguments to be an interface type to allow passing data without mutating shared state. Signed-off-by: Richard Scothern <richard.scothern@gmail.com> Signed-off-by: Richard Scothern <richard.scothern@docker.com>
163 lines
3.6 KiB
Go
163 lines
3.6 KiB
Go
package notifications
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/docker/distribution/digest"
|
|
|
|
"github.com/docker/libtrust"
|
|
|
|
"github.com/docker/distribution/manifest/schema1"
|
|
|
|
"github.com/docker/distribution/registry/api/v2"
|
|
"github.com/docker/distribution/uuid"
|
|
)
|
|
|
|
var (
|
|
// common environment for expected manifest events.
|
|
|
|
repo = "test/repo"
|
|
source = SourceRecord{
|
|
Addr: "remote.test",
|
|
InstanceID: uuid.Generate().String(),
|
|
}
|
|
ub = mustUB(v2.NewURLBuilderFromString("http://test.example.com/"))
|
|
|
|
actor = ActorRecord{
|
|
Name: "test",
|
|
}
|
|
request = RequestRecord{}
|
|
m = schema1.Manifest{
|
|
Name: repo,
|
|
Tag: "latest",
|
|
}
|
|
|
|
sm *schema1.SignedManifest
|
|
payload []byte
|
|
dgst digest.Digest
|
|
)
|
|
|
|
func TestEventBridgeManifestPulled(t *testing.T) {
|
|
|
|
l := createTestEnv(t, testSinkFn(func(events ...Event) error {
|
|
checkCommonManifest(t, EventActionPull, events...)
|
|
|
|
return nil
|
|
}))
|
|
|
|
if err := l.ManifestPulled(repo, sm); err != nil {
|
|
t.Fatalf("unexpected error notifying manifest pull: %v", err)
|
|
}
|
|
}
|
|
|
|
func TestEventBridgeManifestPushed(t *testing.T) {
|
|
l := createTestEnv(t, testSinkFn(func(events ...Event) error {
|
|
checkCommonManifest(t, EventActionPush, events...)
|
|
|
|
return nil
|
|
}))
|
|
|
|
if err := l.ManifestPushed(repo, sm); err != nil {
|
|
t.Fatalf("unexpected error notifying manifest pull: %v", err)
|
|
}
|
|
}
|
|
|
|
func TestEventBridgeManifestDeleted(t *testing.T) {
|
|
l := createTestEnv(t, testSinkFn(func(events ...Event) error {
|
|
checkCommonManifest(t, EventActionDelete, events...)
|
|
|
|
return nil
|
|
}))
|
|
|
|
if err := l.ManifestDeleted(repo, sm); err != nil {
|
|
t.Fatalf("unexpected error notifying manifest pull: %v", err)
|
|
}
|
|
}
|
|
|
|
func createTestEnv(t *testing.T, fn testSinkFn) Listener {
|
|
pk, err := libtrust.GenerateECP256PrivateKey()
|
|
if err != nil {
|
|
t.Fatalf("error generating private key: %v", err)
|
|
}
|
|
|
|
sm, err = schema1.Sign(&m, pk)
|
|
if err != nil {
|
|
t.Fatalf("error signing manifest: %v", err)
|
|
}
|
|
|
|
_, payload, err = sm.Payload()
|
|
if err != nil {
|
|
t.Fatalf("error getting manifest payload: %v", err)
|
|
}
|
|
|
|
dgst = digest.FromBytes(payload)
|
|
|
|
return NewBridge(ub, source, actor, request, fn)
|
|
}
|
|
|
|
func checkCommonManifest(t *testing.T, action string, events ...Event) {
|
|
checkCommon(t, events...)
|
|
|
|
event := events[0]
|
|
if event.Action != action {
|
|
t.Fatalf("unexpected event action: %q != %q", event.Action, action)
|
|
}
|
|
|
|
u, err := ub.BuildManifestURL(repo, dgst.String())
|
|
if err != nil {
|
|
t.Fatalf("error building expected url: %v", err)
|
|
}
|
|
|
|
if event.Target.URL != u {
|
|
t.Fatalf("incorrect url passed: \n%q != \n%q", event.Target.URL, u)
|
|
}
|
|
}
|
|
|
|
func checkCommon(t *testing.T, events ...Event) {
|
|
if len(events) != 1 {
|
|
t.Fatalf("unexpected number of events: %v != 1", len(events))
|
|
}
|
|
|
|
event := events[0]
|
|
|
|
if event.Source != source {
|
|
t.Fatalf("source not equal: %#v != %#v", event.Source, source)
|
|
}
|
|
|
|
if event.Request != request {
|
|
t.Fatalf("request not equal: %#v != %#v", event.Request, request)
|
|
}
|
|
|
|
if event.Actor != actor {
|
|
t.Fatalf("request not equal: %#v != %#v", event.Actor, actor)
|
|
}
|
|
|
|
if event.Target.Digest != dgst {
|
|
t.Fatalf("unexpected digest on event target: %q != %q", event.Target.Digest, dgst)
|
|
}
|
|
|
|
if event.Target.Length != int64(len(payload)) {
|
|
t.Fatalf("unexpected target length: %v != %v", event.Target.Length, len(payload))
|
|
}
|
|
|
|
if event.Target.Repository != repo {
|
|
t.Fatalf("unexpected repository: %q != %q", event.Target.Repository, repo)
|
|
}
|
|
|
|
}
|
|
|
|
type testSinkFn func(events ...Event) error
|
|
|
|
func (tsf testSinkFn) Write(events ...Event) error {
|
|
return tsf(events...)
|
|
}
|
|
|
|
func (tsf testSinkFn) Close() error { return nil }
|
|
|
|
func mustUB(ub *v2.URLBuilder, err error) *v2.URLBuilder {
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
|
|
return ub
|
|
}
|