dkirillov/linters
1
0
Fork 0
forked from TrueCloudLab/linters
Code Pull requests Activity

[#16] noliteral: Refactor

Browse source 
Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
This commit is contained in:
Alexander Chuprov 2024-02-12 16:36:46 +03:00
parent 1b23dd3733
commit 2c4e1d8b53
2 changed files with 51 additions and 44 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
internal/analyzers/noliteral/linter.go
View file

@ -51,12 +51,23 @@ func run(pass *analysis.Pass) (interface{}, error) {
} }
for _, file := range pass.Files { for _, file := range pass.Files {
ast.Inspect(file, func(n ast.Node) bool { ast.Inspect(file, func(n ast.Node) bool {
expr, ok := n.(*ast.CallExpr) switch n.(type) {
if !ok { // log.Error()
case *ast.CallExpr:
if expr, ok := n.(*ast.CallExpr); ok {
return analyzeCallExpr(pass, expr, file)
}
}
return true return true
})
} }
return nil, nil
}
func analyzeCallExpr(pass *analysis.Pass, expr *ast.CallExpr, file *ast.File) bool {
isLog, _ := astutils.IsTargetMethod(expr.Fun, Config.TargetMethods) isLog, _ := astutils.IsTargetMethod(expr.Fun, Config.TargetMethods)
if !isLog || len(expr.Args) == 0 || astutils.HasNoLintComment(pass, expr.Pos()) { if !isLog || len(expr.Args) == 0 || astutils.HasNoLintComment(pass, expr.Pos()) {
return true return true
} }
@ -92,8 +103,4 @@ func run(pass *analysis.Pass) (interface{}, error) {
}) })
return false return false
})
}
return nil, nil
} }

10
internal/analyzers/noliteral/test-case/const-location/positive._go
View file

@ -4,23 +4,23 @@ package logs //declaration package
import ( import (
"fmt" "fmt"
tochno_ne_const_dly_log "git.frostfs.info/TrueCloudLab/frostfs-node/internal/logs"// The alias of the package with constants differs from the one used tochno_ne_dly_const_log "git.frostfs.info/TrueCloudLab/frostfs-node/internal/logs"// The alias of the package with constants differs from the one used
) )
func (c *cfg) info_ok() { func (c *cfg) info_ok() {
c.log.Info(tochno_ne_const_dly_log.MSG) c.log.Info(tochno_ne_dly_const_log.MSG)
} }
func (c *cfg) debug_ok() { func (c *cfg) debug_ok() {
c.log.Debug(tochno_ne_const_dly_log.MSG) c.log.Debug(tochno_ne_dly_const_log.MSG)
} }
func (c *cfg) error_ok() { func (c *cfg) error_ok() {
c.log.Error(tochno_ne_const_dly_log.MSG) c.log.Error(tochno_ne_dly_const_log.MSG)
} }
func (c *cfg) custom_ok_const() { func (c *cfg) custom_ok_const() {
c.log.Abyr(tochno_ne_const_dly_log.MSG) c.log.Abyr(tochno_ne_dly_const_log.MSG)
} }