dkirillov/linters
1
0
Fork 0
forked from TrueCloudLab/linters
Code Pull requests Activity

[#10] linters: Add support for the nolint comment

Browse source 
Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
This commit is contained in:
Alexander Chuprov 2023-08-17 15:28:14 +03:00
parent a2983f6cb8
commit d0450b6301
3 changed files with 17 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
internal/analyzers/noliteral/linter.go
View file

@ -57,7 +57,7 @@ func run(pass *analysis.Pass) (interface{}, error) {
}
isLog, _ := astutils.IsTargetMethod(expr.Fun, Config.TargetMethods)
if !isLog || len(expr.Args) == 0 {
if !isLog || len(expr.Args) == 0 || astutils.HasNoLintComment(pass, expr.Pos()) {
return true
}

2
internal/analyzers/use-strconv/linter.go
View file

@ -71,7 +71,7 @@ func run(pass *analysis.Pass) (interface{}, error) {
stringLiteral, ok := expr.Args[0].(*ast.BasicLit)
if !ok {
if !ok || astutils.HasNoLintComment(pass, expr.Pos()) {
return true
}

15
pkg/ast-utils/ast.go
View file

@ -5,6 +5,8 @@ import (
"go/token"
"strings"
"sync"
"golang.org/x/tools/go/analysis"
)
type aliasCacheKey struct {
@ -94,3 +96,16 @@ func GetPackageName(expr ast.Expr) string {
}
return ""
}
func HasNoLintComment(pass *analysis.Pass, pos token.Pos) bool {
for _, commentGroup := range pass.Files[0].Comments {
if commentGroup.End() < pos {
for _, comment := range commentGroup.List {
if strings.Contains(comment.Text, "nolint") {
return true
}
}
}
}
return false
}