dkirillov/s3-tests
1
0
Fork 0
forked from TrueCloudLab/s3-tests
Code Pull requests Activity

Fix 'If-Modified-Since' format string

Browse source 
According to https://tools.ietf.org/html/rfc7232
header 'If-Modified-Since' should be a correct HTTP-date.
For example: `Tue, 15 Nov 1994 12:45:26 GMT`;
not `1994-11-15T12:45:26.000Z`.

Signed-off-by: Evgenii Gorinov <korvin.lucky@gmail.com>
This commit is contained in:
Evgenii Gorinov 2016-11-09 19:19:13 +03:00 committed by Evgenii Gorinov
parent f2d087ed8a
commit 217f0d520f
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
s3tests/functional/test_s3.py
View file

@ -2435,13 +2435,14 @@ def test_get_object_ifmodifiedsince_failed():
for k in bucket.get_all_keys(): for k in bucket.get_all_keys():
key = k key = k
mtime = time.strptime(key.last_modified, '%Y-%m-%dT%H:%M:%S.%fZ') mtime = datetime.datetime.strptime(key.last_modified, '%Y-%m-%dT%H:%M:%S.%fZ')
after = time.ctime(time.mktime(mtime) + 1) after = mtime + datetime.timedelta(seconds=1)
after_str = time.strftime("%a, %d %b %Y %H:%M:%S GMT", after.timetuple())
time.sleep(1) time.sleep(1)
e = assert_raises(boto.exception.S3ResponseError, bucket.get_key, 'foo', headers={'If-Modified-Since': after}) e = assert_raises(boto.exception.S3ResponseError, bucket.get_key, 'foo', headers={'If-Modified-Since': after_str})
eq(e.status, 304) eq(e.status, 304)
eq(e.reason, 'Not Modified') eq(e.reason, 'Not Modified')