dkirillov/s3-tests
1
0
Fork 0
forked from TrueCloudLab/s3-tests
Code Pull requests Activity

BucketPolicy: donot allow NotPrincipal with Allow Effect

Browse source 
Ref. https://github.com/ceph/ceph/pull/58686

Signed-off-by: Seena Fallah <seenafallah@gmail.com>
This commit is contained in:
Seena Fallah 2024-07-19 20:48:06 +02:00
parent 4eda9c0626
commit 474c1404e2
1 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
s3tests_boto3/functional/test_s3.py
View file

@ -12793,13 +12793,10 @@ def test_get_nonpublicpolicy_acl_bucket_policy_status():
assert resp['PolicyStatus']['IsPublic'] == False assert resp['PolicyStatus']['IsPublic'] == False
def test_get_nonpublicpolicy_deny_bucket_policy_status(): def test_bucket_policy_allow_notprincipal():
bucket_name = get_new_bucket() bucket_name = get_new_bucket()
client = get_client() client = get_client()
resp = client.get_bucket_policy_status(Bucket=bucket_name)
assert resp['PolicyStatus']['IsPublic'] == False
resource1 = "arn:aws:s3:::" + bucket_name resource1 = "arn:aws:s3:::" + bucket_name
resource2 = "arn:aws:s3:::" + bucket_name + "/*" resource2 = "arn:aws:s3:::" + bucket_name + "/*"
policy_document = json.dumps( policy_document = json.dumps(
@ -12816,9 +12813,12 @@ def test_get_nonpublicpolicy_deny_bucket_policy_status():
}] }]
}) })
client.put_bucket_policy(Bucket=bucket_name, Policy=policy_document) e = assert_raises(ClientError,
resp = client.get_bucket_policy_status(Bucket=bucket_name) client.put_bucket_policy, Bucket=bucket_name, Policy=policy_document)
assert resp['PolicyStatus']['IsPublic'] == True status, error_code = _get_status_and_error_code(e.response)
assert status == 400
assert error_code == 'InvalidArgument' or error_code == 'MalformedPolicy'
def test_get_undefined_public_block(): def test_get_undefined_public_block():
bucket_name = get_new_bucket() bucket_name = get_new_bucket()