dkirillov/s3-tests
1
0
Fork 0
forked from TrueCloudLab/s3-tests
Code Pull requests Activity

304 Not Modified tests still expect etag header

Browse source 
test case for https://tracker.ceph.com/issues/45736

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 19c17fa49a)
This commit is contained in:
Casey Bodley 2023-11-20 22:47:28 -05:00 committed by Ali Maredia
parent d50ea9f485
commit e0503c9fcd
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
s3tests_boto3/functional/test_s3.py
View file

@ -3006,6 +3006,7 @@ def test_get_object_ifnonematch_good():
status, error_code = _get_status_and_error_code(e.response) status, error_code = _get_status_and_error_code(e.response)
assert status == 304 assert status == 304
assert e.response['Error']['Message'] == 'Not Modified' assert e.response['Error']['Message'] == 'Not Modified'
assert e.response['ResponseMetadata']['HTTPHeaders']['etag'] == etag
def test_get_object_ifnonematch_failed(): def test_get_object_ifnonematch_failed():
bucket_name = get_new_bucket() bucket_name = get_new_bucket()
@ -3031,6 +3032,7 @@ def test_get_object_ifmodifiedsince_failed():
client = get_client() client = get_client()
client.put_object(Bucket=bucket_name, Key='foo', Body='bar') client.put_object(Bucket=bucket_name, Key='foo', Body='bar')
response = client.get_object(Bucket=bucket_name, Key='foo') response = client.get_object(Bucket=bucket_name, Key='foo')
etag = response['ETag']
last_modified = str(response['LastModified']) last_modified = str(response['LastModified'])
last_modified = last_modified.split('+')[0] last_modified = last_modified.split('+')[0]
@ -3045,6 +3047,7 @@ def test_get_object_ifmodifiedsince_failed():
status, error_code = _get_status_and_error_code(e.response) status, error_code = _get_status_and_error_code(e.response)
assert status == 304 assert status == 304
assert e.response['Error']['Message'] == 'Not Modified' assert e.response['Error']['Message'] == 'Not Modified'
assert e.response['ResponseMetadata']['HTTPHeaders']['etag'] == etag
@pytest.mark.fails_on_dbstore @pytest.mark.fails_on_dbstore
def test_get_object_ifunmodifiedsince_good(): def test_get_object_ifunmodifiedsince_good():