From e9c5cc29e908ddcd96900dba7d819baf1790b511 Mon Sep 17 00:00:00 2001 From: "Sumedh A. Kulkarni" Date: Tue, 5 Apr 2022 04:25:00 -0600 Subject: [PATCH] Fix wrong assertion of the test: `test_buckets_list_ctime` TestName: s3tests_boto3.functional.test_s3:test_buckets_list_ctime Problem: The test creates 5 buckets for a user but in an assertion check, it asserts false if any bucket of the user has CreationTime less than a day prior to current time. Due to this reason the test fails if the user has pre-existing buckets older than a day. Solution: Assert only on the CreationTime of buckets that were created with test execution. Signed-off-by: Sumedh A. Kulkarni Co-developed-by: Bob Ham Signed-off-by: Bob Ham --- s3tests_boto3/functional/test_s3.py | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/s3tests_boto3/functional/test_s3.py b/s3tests_boto3/functional/test_s3.py index 728f97b..47cc525 100644 --- a/s3tests_boto3/functional/test_s3.py +++ b/s3tests_boto3/functional/test_s3.py @@ -5266,13 +5266,17 @@ def test_buckets_list_ctime(): before = datetime.datetime.now(datetime.timezone.utc) - datetime.timedelta(days=1) client = get_client() + buckets = [] for i in range(5): - client.create_bucket(Bucket=get_new_bucket_name()) + name = get_new_bucket_name() + client.create_bucket(Bucket=name) + buckets.append(name) response = client.list_buckets() for bucket in response['Buckets']: - ctime = bucket['CreationDate'] - assert before <= ctime, '%r > %r' % (before, ctime) + if bucket['Name'] in buckets: + ctime = bucket['CreationDate'] + assert before <= ctime, '%r > %r' % (before, ctime) @pytest.mark.fails_on_aws def test_list_buckets_anonymous():