Denis Kirillov dkirillov
  • Joined on 2023-03-06
dkirillov commented on pull request TrueCloudLab/frostfs-s3-gw#527 2024-11-12 10:00:08 +00:00
[#469] List multipart uploads streaming

Why do we use only tNode.ID[0]?

dkirillov commented on pull request TrueCloudLab/frostfs-s3-gw#527 2024-11-12 09:59:45 +00:00
[#469] List multipart uploads streaming

It's better to use more meaningful name.

dkirillov commented on pull request TrueCloudLab/frostfs-s3-gw#527 2024-11-12 09:56:15 +00:00
[#469] List multipart uploads streaming

Consider using approach like here aaca4f84b8/pkg/service/tree/tree.go (L1114)

dkirillov commented on pull request TrueCloudLab/frostfs-s3-gw#527 2024-11-12 09:40:51 +00:00
[#469] List multipart uploads streaming

Result must be sorted by upload-id if some uploads have the same key

dkirillov commented on pull request TrueCloudLab/frostfs-s3-gw#527 2024-11-12 09:27:55 +00:00
[#469] List multipart uploads streaming

Probably we should return error rather than coninue

dkirillov commented on pull request TrueCloudLab/frostfs-s3-gw#527 2024-11-12 09:20:32 +00:00
[#469] List multipart uploads streaming

It seems here we must use next rather than info.

dkirillov commented on pull request TrueCloudLab/frostfs-s3-gw#527 2024-11-12 09:00:38 +00:00
[#469] List multipart uploads streaming

If we add new cache we also should be able configure this

dkirillov commented on pull request TrueCloudLab/frostfs-s3-gw#527 2024-11-12 08:59:34 +00:00
[#469] List multipart uploads streaming

Not only. It also contains Marker for listing v1 and ContinuationToken for listing v2

dkirillov commented on pull request TrueCloudLab/frostfs-s3-gw#527 2024-11-12 08:58:16 +00:00
[#469] List multipart uploads streaming

Why do we change this?

dkirillov commented on pull request TrueCloudLab/frostfs-s3-gw#527 2024-11-12 08:55:27 +00:00
[#469] List multipart uploads streaming

We also have to add AccessBox to this context to be able to get access to tree service. Otherwise currently we get

dkirillov commented on pull request TrueCloudLab/frostfs-s3-gw#527 2024-11-12 08:43:21 +00:00
[#469] List multipart uploads streaming

This isn't changed

dkirillov commented on pull request TrueCloudLab/frostfs-s3-gw#547 2024-11-12 06:47:13 +00:00
[#538] Return headers with 304 Not Modified

Why do we need other headers except ETag and Last-Modified?

dkirillov pushed tag v0.1.2 to TrueCloudLab/s3-tests-parser 2024-11-11 14:11:04 +00:00
dkirillov created pull request TrueCloudLab/frostfs-s3-gw#548 2024-11-11 14:01:16 +00:00
[#539] Fix listing v1 bookmark marker
dkirillov pushed to bugfix/539-fix_listing at dkirillov/frostfs-s3-gw 2024-11-11 14:00:48 +00:00
2f82a5c896 [#539] Fix listing v1 bookmark marker
17d40245de [#505] docs: Add example of uploading file using presigned URL
979d85b046 [#505] authmate: Add flag for headers in generate-presigned-url cmd
539dab8680 [#501] Add the trace id to the logs of middlware
76008d4ba1 [#501] Consider using request logger in logAndSendError
Compare 10 commits »
dkirillov created branch bugfix/539-fix_listing in dkirillov/frostfs-s3-gw 2024-11-11 14:00:47 +00:00
dkirillov created pull request TrueCloudLab/s3-tests-parser#4 2024-11-11 13:57:21 +00:00
WIP: [#2] Correct test groups
dkirillov pushed to feature/correct_test_groups at dkirillov/s3-tests-parser 2024-11-11 13:56:24 +00:00
e30bbe87e9 [#2] Correct test groups
f35917a01d [#2] Add .forgejo files
a7ca907332 [#2] Correct test groups
e54a9c9e6c [#2] Support verbose flag and include
Compare 4 commits »
dkirillov created branch feature/correct_test_groups in dkirillov/s3-tests-parser 2024-11-11 13:56:23 +00:00
dkirillov commented on pull request TrueCloudLab/frostfs-s3-gw#546 2024-11-11 11:52:01 +00:00
[#540] Add md5 S3Tests compatability

Why don't we have the same test for regular PutObject?