dstepanov-yadro/frostfs-api-go
1
0
Fork 0
forked from TrueCloudLab/frostfs-api-go
Code Issues Pull requests Projects Releases Packages Wiki Activity
1344 commits 13 branches 61 tags 7.1 MiB
Commit graph

30 commits

Author SHA1 Message Date
Evgenii Stratonikov
29f2157563
[#123] protogen: Treat bytes field as non-nullable 
In protobuf 3.12 they have added an support for `optional` keyword,
which has made it into the main branch in 3.15.
https://github.com/protocolbuffers/protobuf/blob/main/docs/implementing_proto3_presence.md
https://github.com/protocolbuffers/protobuf/blob/v3.12.0/docs/field_presence.md#presence-in-proto3-apis

This means that without an explicit `optional` keyword field presence
for scalars is not tracked, thus empty string in JSON should be
unmarshaled to a nil byte slice. Relevant decoding code and tests from
protojson:
fb995f184a/internal/impl/message_reflect_field.go (L327)
fb995f184a/encoding/protojson/decode_test.go (L134)
fb995f184a/encoding/protojson/decode_test.go (L156)

We do not support `optional` keyword and the generator will fail if it sees on.
So only implement the default behaviour.

Refs #122

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2024-10-11 14:40:54 +03:00
Evgenii Stratonikov
29c522d5d8 [#122] protogen: Always marshal empty fields 
This is how it was done previously:
a0a9b765f3/rpc/message/encoding.go (L31)

The tricky part is `[]byte` which is marshaled as `null` by easyjson
helper, but as `""` by protojson.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2024-10-07 15:05:43 +03:00
Evgenii Stratonikov
d9a604fbc1 [#120] proto/test: Unskip protojson compatibility test 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2024-10-01 14:18:52 +03:00
Evgenii Stratonikov
287e98ad67 [#120] proto/test: Add protojson compatibility test 
It is failing, thus is skipped.
But implement it now to make it easier to see it failing.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2024-10-01 14:11:43 +03:00
Evgenii Stratonikov
5e1c6a908f [#111] protogen: Emit slice of messages without a pointer 
```
goos: linux
goarch: amd64
pkg: git.frostfs.info/TrueCloudLab/frostfs-api-go/v2/refs
cpu: 11th Gen Intel(R) Core(TM) i5-1135G7 @ 2.40GHz
                                              │      old      │                 new                  │
                                              │    sec/op     │    sec/op     vs base                │
ObjectIDSlice/0_elements/to_grpc_message-8       3.193n ±  2%   3.242n ±  0%   +1.50% (p=0.034 n=10)
ObjectIDSlice/0_elements/from_grpc_message-8     3.197n ±  2%   3.343n ±  1%   +4.57% (p=0.000 n=10)
ObjectIDSlice/0_elements/marshal-8               5.666n ±  3%   5.642n ±  0%   -0.42% (p=0.000 n=10)
ObjectIDSlice/1_elements/to_grpc_message-8       53.10n ±  6%   29.78n ± 12%  -43.92% (p=0.000 n=10)
ObjectIDSlice/1_elements/from_grpc_message-8     28.99n ±  5%   29.77n ±  7%        ~ (p=0.165 n=10)
ObjectIDSlice/1_elements/marshal-8               49.08n ±  7%   50.72n ±  6%        ~ (p=0.218 n=10)
ObjectIDSlice/50_elements/to_grpc_message-8     1652.5n ±  7%   277.2n ±  1%  -83.22% (p=0.000 n=10)
ObjectIDSlice/50_elements/from_grpc_message-8    261.2n ± 11%   226.7n ± 15%  -13.19% (p=0.003 n=10)
ObjectIDSlice/50_elements/marshal-8              1.512µ ±  6%   1.514µ ±  6%        ~ (p=0.955 n=10)
geomean                                          52.15n         39.99n        -23.31%

                                              │      old       │                  new                   │
                                              │      B/op      │     B/op      vs base                  │
ObjectIDSlice/0_elements/to_grpc_message-8        0.000 ± 0%       0.000 ± 0%        ~ (p=1.000 n=10) ¹
ObjectIDSlice/0_elements/from_grpc_message-8      0.000 ± 0%       0.000 ± 0%        ~ (p=1.000 n=10) ¹
ObjectIDSlice/0_elements/marshal-8                0.000 ± 0%       0.000 ± 0%        ~ (p=1.000 n=10) ¹
ObjectIDSlice/1_elements/to_grpc_message-8        32.00 ± 0%       24.00 ± 0%  -25.00% (p=0.000 n=10)
ObjectIDSlice/1_elements/from_grpc_message-8      24.00 ± 0%       24.00 ± 0%        ~ (p=1.000 n=10) ¹
ObjectIDSlice/1_elements/marshal-8                48.00 ± 0%       48.00 ± 0%        ~ (p=1.000 n=10) ¹
ObjectIDSlice/50_elements/to_grpc_message-8     1.578Ki ± 0%     1.250Ki ± 0%  -20.79% (p=0.000 n=10)
ObjectIDSlice/50_elements/from_grpc_message-8   1.250Ki ± 0%     1.250Ki ± 0%        ~ (p=1.000 n=10) ¹
ObjectIDSlice/50_elements/marshal-8             2.000Ki ± 0%     2.000Ki ± 0%        ~ (p=1.000 n=10) ¹
geomean                                                      ²                  -5.62%                ²
¹ all samples are equal
² summaries must be >0 to compute geomean

                                              │      old      │                 new                  │
                                              │   allocs/op   │ allocs/op   vs base                  │
ObjectIDSlice/0_elements/to_grpc_message-8       0.000 ± 0%     0.000 ± 0%        ~ (p=1.000 n=10) ¹
ObjectIDSlice/0_elements/from_grpc_message-8     0.000 ± 0%     0.000 ± 0%        ~ (p=1.000 n=10) ¹
ObjectIDSlice/0_elements/marshal-8               0.000 ± 0%     0.000 ± 0%        ~ (p=1.000 n=10) ¹
ObjectIDSlice/1_elements/to_grpc_message-8       2.000 ± 0%     1.000 ± 0%  -50.00% (p=0.000 n=10)
ObjectIDSlice/1_elements/from_grpc_message-8     1.000 ± 0%     1.000 ± 0%        ~ (p=1.000 n=10) ¹
ObjectIDSlice/1_elements/marshal-8               1.000 ± 0%     1.000 ± 0%        ~ (p=1.000 n=10) ¹
ObjectIDSlice/50_elements/to_grpc_message-8     51.000 ± 0%     1.000 ± 0%  -98.04% (p=0.000 n=10)
ObjectIDSlice/50_elements/from_grpc_message-8    1.000 ± 0%     1.000 ± 0%        ~ (p=1.000 n=10) ¹
ObjectIDSlice/50_elements/marshal-8              1.000 ± 0%     1.000 ± 0%        ~ (p=1.000 n=10) ¹
geomean                                                     ²               -40.18%                ²
¹ all samples are equal
² summaries must be >0 to compute geomean
```

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2024-08-28 11:53:08 +03:00
Evgenii Stratonikov
a2025376fc [#111] proto/test: Add repeated message test 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2024-08-28 11:53:08 +03:00
Evgenii Stratonikov
981dc785f3 [#107] proto/test: Add oneof test 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2024-08-26 14:36:19 +03:00
Evgenii Stratonikov
7be31eb847 [#77] protogen: Add tests for JSON format 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2024-08-19 10:47:00 +03:00
Evgenii Stratonikov
adb7c602d7 [#77] protogen: Initial implementation 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2024-08-19 10:47:00 +03:00
Evgenii Stratonikov
47a48969b0 [#103] proto: Test end-to-end scenario 
Test the generated code, do not write yet another marshaling routine in
tests.

Before:
```
ok      git.frostfs.info/TrueCloudLab/frostfs-api-go/v2/util/proto      0.003s  coverage: 55.6% of statements
```

After:
```
ok      git.frostfs.info/TrueCloudLab/frostfs-api-go/v2/util/proto      0.003s  coverage: 80.0% of statements
```

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2024-08-09 11:18:17 +03:00
Evgenii Stratonikov
f517e39491 [#91] protogen: Support unpacked repeated uint64 fields 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2024-07-16 14:39:20 +03:00
Evgenii Stratonikov
610c450a65 [#90] proto/test: Fix go vet warnings 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2024-07-15 16:40:21 +03:00
Evgenii Stratonikov
a85146250b [#68] Makefile: Use gofumpt for formatting 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2024-03-14 10:31:58 +03:00
Evgenii Stratonikov
e9e7901f67 [#27] util/proto: Fix staticcheck warning 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-05-03 14:15:56 +03:00
Alex Vanin
f69d2ad83c Rename package name 
Due to source code relocation from GitHub.

Signed-off-by: Alex Vanin <a.vanin@yadro.com>
 2023-03-07 13:42:36 +03:00
Evgenii Stratonikov
1351b6656d Move to frostfs-api 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2022-12-12 17:40:48 +03:00
Evgenii Stratonikov
9e17cdfc76 [#413] util/proto: Marshal repeated []byte fields correctly 
Signed-off-by: Evgenii Stratonikov <evgeniy@nspcc.ru>
 2022-08-27 11:06:58 +03:00
Evgenii Stratonikov
84d981e88e util/proto: do not return error from primitive marshalers 
Signed-off-by: Evgenii Stratonikov <evgeniy@nspcc.ru>
 2022-04-21 15:07:57 +03:00
Leonard Lyubich
b0a2b73650 [#355] util/proto: Support fixed32 fields 
Implement `Fixed32Marshal` / `Fixed32Size` functions which allow to work
with protobuf fixed32 fields.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
 2021-11-18 17:40:33 +03:00
Leonard Lyubich
25da5d2e13 Add v2 version to go module name 
Replace all elements from `v2` to root directory.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
 2021-11-17 15:29:33 +03:00
Evgenii Stratonikov
9ddfcdfbba [#277] go.mod: remove pkg/errors 
Use stdlib `errors` instead.

Signed-off-by: Evgenii Stratonikov <evgeniy@nspcc.ru>
 2021-05-19 11:14:56 +03:00
Leonard Lyubich
0cbb8d0913 [#265] proto: Implement functions for double (float64) protobuf data type 
Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
 2021-03-25 11:20:34 +03:00
Leonard Lyubich
51e8e318c2 [#233] proto: Implement functions for fixed64 protobuf data type 
Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
 2020-12-25 16:20:34 +03:00
Alex Vanin
8351c78f58 [#172] Use protobuf v2 API for go 
Signed-off-by: Alex Vanin <alexey@nspcc.ru>
 2020-10-20 13:45:14 +03:00
Alex Vanin
a68252c956 Add stable marshal helpers for repeated fields 
Signed-off-by: Alex Vanin <alexey@nspcc.ru>
 2020-09-18 10:41:07 +03:00
Alex Vanin
a7a8fc33bb Add stable marshaler for enums 
Signed-off-by: Alex Vanin <alexey@nspcc.ru>
 2020-09-18 10:41:04 +03:00
Alex Vanin
f8482381fd Add stable marshaller helper for ints 
Signed-off-by: Alex Vanin <alexey@nspcc.ru>
 2020-09-18 10:41:01 +03:00
Alex Vanin
89bd8f3915 Add stable marshaller helper for bool 
Signed-off-by: Alex Vanin <alexey@nspcc.ru>
 2020-09-18 10:40:59 +03:00
Alex Vanin
311b76b75b Add proto marshal helper for string 
Signed-off-by: Alex Vanin <alexey@nspcc.ru>
 2020-09-18 10:40:56 +03:00
Alex Vanin
41f9c50424 Add proto marshal helper for bytes 
Signed-off-by: Alex Vanin <alexey@nspcc.ru>
 2020-09-18 10:40:53 +03:00