dstepanov-yadro/frostfs-node
1
0
Fork 0
forked from TrueCloudLab/frostfs-node
Code Issues Pull requests Projects Releases Packages Wiki Activity

[#1383] object: Add restrictions for Patch method

Browse source 
* `Patch` can't be applied for non-regular type object (tombstones,
  locks etc.)
* Complex object parts can't be patched. So, if an object has EC/Split
  header, it won't be patched.

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
This commit is contained in:
Airat Arifullin 2024-09-18 12:13:15 +03:00
parent 3441fff05d
commit 61d5e140e0
1 changed files with 19 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
pkg/services/object/patch/streamer.go
View file

@ -57,12 +57,31 @@ func toFullObjectHeader(hdr *objectSDK.Object) objectV2.GetHeaderPart {
return hs return hs
} }
func isLinkObject(hdr *objectV2.HeaderWithSignature) bool {
split := hdr.GetHeader().GetSplit()
return len(split.GetChildren()) > 0 && split.GetParent() != nil
}
func isComplexObjectPart(hdr *objectV2.HeaderWithSignature) bool {
return hdr.GetHeader().GetEC() != nil || hdr.GetHeader().GetSplit() != nil
}
func (s *Streamer) init(ctx context.Context, req *objectV2.PatchRequest) error { func (s *Streamer) init(ctx context.Context, req *objectV2.PatchRequest) error {
hdrWithSig, addr, err := s.readHeader(ctx, req) hdrWithSig, addr, err := s.readHeader(ctx, req)
if err != nil { if err != nil {
return err return err
} }
if hdrWithSig.GetHeader().GetObjectType() != objectV2.TypeRegular {
return errors.New("non-regular object can't be patched")
}
if isLinkObject(hdrWithSig) {
return errors.New("linking object can't be patched")
}
if isComplexObjectPart(hdrWithSig) {
return errors.New("complex object parts can't be patched")
}
commonPrm, err := util.CommonPrmFromV2(req) commonPrm, err := util.CommonPrmFromV2(req)
if err != nil { if err != nil {
return err return err