From 68c7f6ce8a71d57b2171a0495cfb209c0e5e754a Mon Sep 17 00:00:00 2001 From: Pavel Karpy Date: Thu, 17 Jun 2021 18:08:08 +0300 Subject: [PATCH] [#613] pkg/innerring/reputation: Add `FIXME` to `ToV2` usage Signed-off-by: Pavel Karpy --- pkg/innerring/processors/reputation/handlers.go | 1 + pkg/innerring/processors/reputation/process_put.go | 2 ++ 2 files changed, 3 insertions(+) diff --git a/pkg/innerring/processors/reputation/handlers.go b/pkg/innerring/processors/reputation/handlers.go index 4d3c8ab81..26cfa4712 100644 --- a/pkg/innerring/processors/reputation/handlers.go +++ b/pkg/innerring/processors/reputation/handlers.go @@ -12,6 +12,7 @@ func (rp *Processor) handlePutReputation(ev event.Event) { put := ev.(reputationEvent.Put) peerID := put.PeerID() + // FIXME: do not use `ToV2` method outside neofs-api-go library rp.log.Info("notification", zap.String("type", "reputation put"), zap.String("peer_id", hex.EncodeToString(peerID.ToV2().GetPublicKey()))) diff --git a/pkg/innerring/processors/reputation/process_put.go b/pkg/innerring/processors/reputation/process_put.go index f71d1f805..6a0fd28e7 100644 --- a/pkg/innerring/processors/reputation/process_put.go +++ b/pkg/innerring/processors/reputation/process_put.go @@ -56,6 +56,7 @@ func (rp *Processor) processPut(epoch uint64, id apireputation.PeerID, value api err := rp.reputationWrp.Put(args) if err != nil { + // FIXME: do not use `ToV2` method outside neofs-api-go library rp.log.Warn("can't send approval tx for reputation value", zap.String("peer_id", hex.EncodeToString(id.ToV2().GetPublicKey())), zap.String("error", err.Error())) @@ -69,6 +70,7 @@ func (rp *Processor) checkManagers(e uint64, mng apireputation.PeerID, peer apir } for _, m := range mm { + // FIXME: do not use `ToV2` method outside neofs-api-go library if bytes.Equal(mng.ToV2().GetPublicKey(), m.PublicKey()) { return nil }