From f4c71cea659d6966f753ff9d0bc157012d616cb4 Mon Sep 17 00:00:00 2001
From: Evgenii Stratonikov <e.stratonikov@yadro.com>
Date: Mon, 26 Jun 2023 13:58:22 +0300
Subject: [PATCH] [#1] *: Replace outdated FIXME/TODO links

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
---
 cmd/frostfs-cli/modules/container/list.go         | 3 ++-
 cmd/frostfs-cli/modules/container/list_objects.go | 3 ++-
 pkg/core/object/fmt.go                            | 1 -
 pkg/innerring/processors/container/common.go      | 3 ---
 pkg/local_object_storage/metabase/select.go       | 1 -
 pkg/services/object/internal/client/client.go     | 2 +-
 6 files changed, 5 insertions(+), 8 deletions(-)

diff --git a/cmd/frostfs-cli/modules/container/list.go b/cmd/frostfs-cli/modules/container/list.go
index 1c9e4767f..189cc05c7 100644
--- a/cmd/frostfs-cli/modules/container/list.go
+++ b/cmd/frostfs-cli/modules/container/list.go
@@ -78,7 +78,8 @@ var listContainersCmd = &cobra.Command{
 			if flagVarListPrintAttr {
 				cnr.IterateAttributes(func(key, val string) {
 					if !strings.HasPrefix(key, container.SysAttributePrefix) && !strings.HasPrefix(key, container.SysAttributePrefixNeoFS) {
-						// FIXME(@cthulhu-rider): neofs-sdk-go#314 use dedicated method to skip system attributes
+						// FIXME(@cthulhu-rider): https://git.frostfs.info/TrueCloudLab/frostfs-sdk-go/issues/97
+						//	Use dedicated method to skip system attributes.
 						cmd.Printf("  %s: %s\n", key, val)
 					}
 				})
diff --git a/cmd/frostfs-cli/modules/container/list_objects.go b/cmd/frostfs-cli/modules/container/list_objects.go
index e417560e8..d00cc3576 100644
--- a/cmd/frostfs-cli/modules/container/list_objects.go
+++ b/cmd/frostfs-cli/modules/container/list_objects.go
@@ -71,7 +71,8 @@ var listContainerObjectsCmd = &cobra.Command{
 					for i := range attrs {
 						attrKey := attrs[i].Key()
 						if !strings.HasPrefix(attrKey, v2object.SysAttributePrefix) && !strings.HasPrefix(attrKey, v2object.SysAttributePrefixNeoFS) {
-							// FIXME(@cthulhu-rider): neofs-sdk-go#226 use dedicated method to skip system attributes
+							// FIXME(@cthulhu-rider): https://git.frostfs.info/TrueCloudLab/frostfs-sdk-go/issues/97
+							//	Use dedicated method to skip system attributes.
 							cmd.Printf("  %s: %s\n", attrKey, attrs[i].Value())
 						}
 					}
diff --git a/pkg/core/object/fmt.go b/pkg/core/object/fmt.go
index 946cfc462..bfd22c9ae 100644
--- a/pkg/core/object/fmt.go
+++ b/pkg/core/object/fmt.go
@@ -133,7 +133,6 @@ func (v *FormatValidator) Validate(ctx context.Context, obj *object.Object, unpr
 }
 
 func (v *FormatValidator) validateSignatureKey(obj *object.Object) error {
-	// FIXME(@cthulhu-rider): temp solution, see neofs-sdk-go#233
 	sig := obj.Signature()
 	if sig == nil {
 		// TODO(@cthulhu-rider): #1387 use "const" error
diff --git a/pkg/innerring/processors/container/common.go b/pkg/innerring/processors/container/common.go
index 375e4c179..97eb6f559 100644
--- a/pkg/innerring/processors/container/common.go
+++ b/pkg/innerring/processors/container/common.go
@@ -63,7 +63,6 @@ func (cp *Processor) verifySignature(v signatureVerificationData) error {
 	}
 
 	if keyProvided {
-		// TODO(@cthulhu-rider): #1387 use another approach after neofs-sdk-go#233
 		var idFromKey user.ID
 		user.IDFromKey(&idFromKey, (ecdsa.PublicKey)(key))
 
@@ -118,8 +117,6 @@ func (cp *Processor) verifyByTokenSession(v signatureVerificationData, key *fros
 		return errors.New("invalid session token signature")
 	}
 
-	// FIXME(@cthulhu-rider): #1387 check token is signed by container owner, see neofs-sdk-go#233
-
 	if keyProvided && !tok.AssertAuthKey(key) {
 		return errors.New("signed with a non-session key")
 	}
diff --git a/pkg/local_object_storage/metabase/select.go b/pkg/local_object_storage/metabase/select.go
index 1f32d2cde..0f53a8f36 100644
--- a/pkg/local_object_storage/metabase/select.go
+++ b/pkg/local_object_storage/metabase/select.go
@@ -572,6 +572,5 @@ func blindlyProcess(fs object.SearchFilters) bool {
 
 // returns true if string key is a reserved system filter key.
 func isSystemKey(key string) bool {
-	// FIXME: #1147 version-dependent approach
 	return strings.HasPrefix(key, v2object.ReservedFilterPrefix)
 }
diff --git a/pkg/services/object/internal/client/client.go b/pkg/services/object/internal/client/client.go
index 8214c784d..17bf6a40f 100644
--- a/pkg/services/object/internal/client/client.go
+++ b/pkg/services/object/internal/client/client.go
@@ -81,7 +81,7 @@ type readPrmCommon struct {
 //
 // By default current epoch on the server will be used.
 func (x *readPrmCommon) SetNetmapEpoch(_ uint64) {
-	// FIXME: (neofs-node#1194) not supported by client
+	// FIXME(@fyrchik): https://git.frostfs.info/TrueCloudLab/frostfs-node/issues/465
 }
 
 // GetObjectPrm groups parameters of GetObject operation.