dstepanov-yadro/neoneo-go
1
0
Fork 0
forked from TrueCloudLab/neoneo-go
Code Pull requests Activity
neoneo-go/pkg/vm/stackitem/serialization_test.go

41 lines
765 B
Go
Raw Normal View History

stackitem: add limit to serialized items Standard binary serialization/deserialization is mostly used in VM to put/get elements into/from storage, so they never should exceed MaxSize (otherwise one won't be able to deserialize these items). This patch leaves EncodeBinaryStackItem unprotected, but that's a streaming interface, so it's up to the user of it to ensure its appropriate use (and our uses are mostly for native contract's data, so they're fine).
2021-07-06 16:34:02 +00:00
package stackitem
import (
stackitem: rework error handling Return good named errors everywhere, export appropriate constants, make errors.Is() work.
2021-07-06 21:18:00 +00:00
"errors"
stackitem: add limit to serialized items Standard binary serialization/deserialization is mostly used in VM to put/get elements into/from storage, so they never should exceed MaxSize (otherwise one won't be able to deserialize these items). This patch leaves EncodeBinaryStackItem unprotected, but that's a streaming interface, so it's up to the user of it to ensure its appropriate use (and our uses are mostly for native contract's data, so they're fine).
2021-07-06 16:34:02 +00:00
"testing"
stackitem: add benchmark for serialization routines Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>
2021-07-09 11:35:28 +00:00
"github.com/nspcc-dev/neo-go/pkg/io"
stackitem: add limit to serialized items Standard binary serialization/deserialization is mostly used in VM to put/get elements into/from storage, so they never should exceed MaxSize (otherwise one won't be able to deserialize these items). This patch leaves EncodeBinaryStackItem unprotected, but that's a streaming interface, so it's up to the user of it to ensure its appropriate use (and our uses are mostly for native contract's data, so they're fine).
2021-07-06 16:34:02 +00:00
"github.com/stretchr/testify/require"
)
func TestSerializationMaxErr(t *testing.T) {
base := make([]byte, MaxSize/2+1)
item := Make(base)
stackitem: rework error handling Return good named errors everywhere, export appropriate constants, make errors.Is() work.
2021-07-06 21:18:00 +00:00
// Pointer is unserializable, but we specifically want to catch ErrTooBig.
arr := []Item{item, item.Dup(), NewPointer(0, []byte{})}
stackitem: add limit to serialized items Standard binary serialization/deserialization is mostly used in VM to put/get elements into/from storage, so they never should exceed MaxSize (otherwise one won't be able to deserialize these items). This patch leaves EncodeBinaryStackItem unprotected, but that's a streaming interface, so it's up to the user of it to ensure its appropriate use (and our uses are mostly for native contract's data, so they're fine).
2021-07-06 16:34:02 +00:00
aitem := Make(arr)
stackitem: remove Item/StackItem from function names They're useless in a package named 'stackitem', make this package a bit more user-friendly.
2021-07-06 16:56:23 +00:00
_, err := Serialize(item)
stackitem: add limit to serialized items Standard binary serialization/deserialization is mostly used in VM to put/get elements into/from storage, so they never should exceed MaxSize (otherwise one won't be able to deserialize these items). This patch leaves EncodeBinaryStackItem unprotected, but that's a streaming interface, so it's up to the user of it to ensure its appropriate use (and our uses are mostly for native contract's data, so they're fine).
2021-07-06 16:34:02 +00:00
require.NoError(t, err)
stackitem: remove Item/StackItem from function names They're useless in a package named 'stackitem', make this package a bit more user-friendly.
2021-07-06 16:56:23 +00:00
_, err = Serialize(aitem)
stackitem: rework error handling Return good named errors everywhere, export appropriate constants, make errors.Is() work.
2021-07-06 21:18:00 +00:00
require.True(t, errors.Is(err, ErrTooBig), err)
stackitem: add limit to serialized items Standard binary serialization/deserialization is mostly used in VM to put/get elements into/from storage, so they never should exceed MaxSize (otherwise one won't be able to deserialize these items). This patch leaves EncodeBinaryStackItem unprotected, but that's a streaming interface, so it's up to the user of it to ensure its appropriate use (and our uses are mostly for native contract's data, so they're fine).
2021-07-06 16:34:02 +00:00
}
stackitem: add benchmark for serialization routines Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>
2021-07-09 11:35:28 +00:00
func BenchmarkEncodeBinary(b *testing.B) {
arr := getBigArray(15)
w := io.NewBufBinWriter()
b.ResetTimer()
b.ReportAllocs()
for i := 0; i < b.N; i++ {
w.Reset()
EncodeBinary(arr, w.BinWriter)
if w.Err != nil {
b.FailNow()
}
}
}
Copy permalink