dstepanov-yadro/neoneo-go
1
0
Fork 0
forked from TrueCloudLab/neoneo-go
Code Pull requests Activity

config: use string type for Port

Browse source 
6b4dd5703e made it to be a uint16 which was
somewhat important for RPC, but now it's irrelevant and the fact that it was a
string in some cases may lead to errors like these:

  failed to unmarshal config YAML: yaml: unmarshal errors:
    line 48: cannot unmarshal !!str `20011` into uint16
    line 52: cannot unmarshal !!str `40001` into uint16

So for maximum backwards compatibility we better have string here and
eventually it'll be deleted anyway.
This commit is contained in:
Roman Khimov 2022-12-07 21:16:12 +03:00
parent 81d755736c
commit 0d65071abc
3 changed files with 5 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
pkg/config/basic_service.go
View file

@ -2,7 +2,6 @@ package config
import ( import (
"net" "net"
"strconv"
) )
// BasicService is used as a simple base for node services like Pprof, RPC or // BasicService is used as a simple base for node services like Pprof, RPC or
@ -12,7 +11,7 @@ type BasicService struct {
// Deprecated: please, use Addresses section instead. This field will be removed later. // Deprecated: please, use Addresses section instead. This field will be removed later.
Address *string `yaml:"Address,omitempty"` Address *string `yaml:"Address,omitempty"`
// Deprecated: please, use Addresses section instead. This field will be removed later. // Deprecated: please, use Addresses section instead. This field will be removed later.
Port *uint16 `yaml:"Port,omitempty"` Port *string `yaml:"Port,omitempty"`
// Addresses holds the list of bind addresses in the form of "address:port". // Addresses holds the list of bind addresses in the form of "address:port".
Addresses []string `yaml:"Addresses"` Addresses []string `yaml:"Addresses"`
} }
@ -25,7 +24,7 @@ func (s BasicService) GetAddresses() []string {
if s.Address != nil || s.Port != nil { //nolint:staticcheck // SA1019: s.Address is deprecated if s.Address != nil || s.Port != nil { //nolint:staticcheck // SA1019: s.Address is deprecated
var ( var (
addr string addr string
port uint16 port string
) )
if s.Address != nil { //nolint:staticcheck // SA1019: s.Address is deprecated if s.Address != nil { //nolint:staticcheck // SA1019: s.Address is deprecated
addr = *s.Address //nolint:staticcheck // SA1019: s.Address is deprecated addr = *s.Address //nolint:staticcheck // SA1019: s.Address is deprecated
@ -33,7 +32,7 @@ func (s BasicService) GetAddresses() []string {
if s.Port != nil { //nolint:staticcheck // SA1019: s.Port is deprecated if s.Port != nil { //nolint:staticcheck // SA1019: s.Port is deprecated
port = *s.Port //nolint:staticcheck // SA1019: s.Port is deprecated port = *s.Port //nolint:staticcheck // SA1019: s.Port is deprecated
} }
addrs = append(addrs, net.JoinHostPort(addr, strconv.FormatUint(uint64(port), 10))) addrs = append(addrs, net.JoinHostPort(addr, port))
} }
return addrs return addrs
} }

2
pkg/config/basic_service_test.go
View file

@ -8,7 +8,7 @@ import (
func TestBasicService_GetAddresses(t *testing.T) { func TestBasicService_GetAddresses(t *testing.T) {
addr := "1.2.3.4" addr := "1.2.3.4"
port := uint16(1234) port := "1234"
s := BasicService{ s := BasicService{
Enabled: false, Enabled: false,
Address: &addr, Address: &addr,

2
pkg/config/rpc_config_test.go
View file

@ -20,5 +20,5 @@ MaxGasInvoke: 15
err := yaml.Unmarshal([]byte(data), &cfg) err := yaml.Unmarshal([]byte(data), &cfg)
require.NoError(t, err) require.NoError(t, err)
require.True(t, cfg.Enabled) require.True(t, cfg.Enabled)
require.Equal(t, uint16(10332), *cfg.Port) require.Equal(t, "10332", *cfg.Port)
} }