dstepanov-yadro/neoneo-go
1
0
Fork 0
forked from TrueCloudLab/neoneo-go
Code Pull requests Activity

rpcclient: make Notary Actor follow the request creation doc

Browse source 
All Notary contract witnesses in incomplete transaction (both main
and fallback) may either have invocation scripts pushing dummy signature
on stack or be empty, both ways are OK. Notary actor keeps main tx's
Notary witness empty and keeps fallback tx's Notary witness filled
with dummy signature.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
This commit is contained in:
Anna Shaleva 2023-04-19 17:18:04 +03:00 committed by Roman Khimov
parent 60e6fe05a7
commit 3bf8192f98
1 changed files with 13 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
docs/notary.md
View file

@ -356,9 +356,9 @@ subpackage with an example written in Go doc.
with `Deployed` set to `false` and `Script` set to the signer's verification with `Deployed` set to `false` and `Script` set to the signer's verification
script. script.
- An account for a notary signer is **just a placeholder** and should have - An account for a notary signer is **just a placeholder** and should have
`Contract` field with `Deployed` set to `false`, i.e. the default value for `Contract` field with `Deployed` set to `true`. Its `Invocation` witness script
`Contract` field. That's needed to skip notary verification during regular parameters will be guessed by the `verify` method signature of Notary contract
network fee calculation at the next step. during the network fee calculation at the next step.
6. Fill in the main transaction `Nonce` field. 6. Fill in the main transaction `Nonce` field.
7. Construct a list of main transactions witnesses (that will be `Scripts` 7. Construct a list of main transactions witnesses (that will be `Scripts`
@ -367,11 +367,17 @@ subpackage with an example written in Go doc.
- A contract-based witness should have `Invocation` script that pushes arguments - A contract-based witness should have `Invocation` script that pushes arguments
on stack (it may be empty) and empty `Verification` script. If multiple notary on stack (it may be empty) and empty `Verification` script. If multiple notary
requests provide different `Invocation` scripts, the first one will be used requests provide different `Invocation` scripts, the first one will be used
to construct contract-based witness. to construct contract-based witness. If non-empty `Invocation` script is
specified then it will be taken into account during network fee calculation.
In case of an empty `Invocation` script, its parameters will be guessed from
the contract's `verify` signature during network fee calculation.
- A **Notary contract witness** (which is also a contract-based witness) should - A **Notary contract witness** (which is also a contract-based witness) should
have empty `Verification` script. `Invocation` script should be of the form have empty `Verification` script. `Invocation` script should be either empty
[opcode.PUSHDATA1, 64, make([]byte, 64)...], i.e. to be a placeholder for (allowed for main transaction and forbidden for fallback transaction) or of
a notary contract signature. the form [opcode.PUSHDATA1, 64, make([]byte, 64)...] (allowed for main
transaction and required for fallback transaction by the Notary subsystem to
pass verification), i.e. to be a placeholder for a notary contract signature.
Both ways are OK for network fee calculation.
- A standard signature witness must have regular `Verification` script filled - A standard signature witness must have regular `Verification` script filled
even if the `Invocation` script is to be collected from other notary even if the `Invocation` script is to be collected from other notary
requests. requests.